[jira] [Commented] (FLINK-5324) JVM Opitons will be work both for YarnApplicationMasterRunner and YarnTaskManager with yarn mode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834543#comment-15834543 ] 

ASF GitHub Bot commented on FLINK-5324:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2994
  
    I would like to pick up this pull request.
    How about we interpret the `env.java.opts` as "common options" that are passes to both JobManager and TaskManager. Then we additionally define options specific for JobManager / TaskManager / AppMaster:
    
      - `env.java.opts.taskmanager`
      - `env.java.opts.jobmanager`
      - `env.java.opts.appmaster`
    
    The TaskManager should then use the  `env.java.opts.taskmanager` + `env.java.opts` options.
    
    Can you also use the new options abstraction for this?
    https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOptions.java



> JVM Opitons will be work both for YarnApplicationMasterRunner and YarnTaskManager with yarn mode
> ------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-5324
>                 URL: https://issues.apache.org/jira/browse/FLINK-5324
>             Project: Flink
>          Issue Type: Bug
>          Components: YARN
>    Affects Versions: 1.1.3
>            Reporter: yuemeng
>            Priority: Critical
>         Attachments: 0001-FLINK-5324-yarn-JVM-Opitons-will-work-for-both-YarnA.patch
>
>
> YarnApplicationMasterRunner and YarnTaskManager both use follow code to get jvm options
> {code}
> final String javaOpts = flinkConfiguration.getString(ConfigConstants.FLINK_JVM_OPTIONS, "")
> {code}
> so when we add some jvm options for one of them ,it will be both worked



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)