[I] Deprecate clustering with row writer [hudi]

["hudi-bot (via GitHub)" <gi...@apache.org>]

hudi-bot opened a new issue, #17341:
URL: https://github.com/apache/hudi/issues/17341

   Clustering row writer followup: is it even required since we are going w/ new FG reader flow now?
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-8749
   - Type: Sub-task
   - Parent: https://issues.apache.org/jira/browse/HUDI-9107
   - Fix version(s):
     - 1.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Deprecate clustering with row writer [hudi]

["rangareddy (via GitHub)" <gi...@apache.org>]

rangareddy commented on issue #17341:
URL: https://github.com/apache/hudi/issues/17341#issuecomment-5351235019

   This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8749).
   
   **Findings: not done - the row-writer clustering path is still the default, not deprecated.**
   
   `hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java:109`:
   
   ```java
   boolean canUseRowWriter = getWriteConfig().getBooleanOrDefault("hoodie.datasource.write.row.writer.enable", true);
   ```
   
   Two things stand out there: the key is a hardcoded string rather than a reference to the `ConfigProperty`, and the default is `true`, so row-writer clustering is what runs unless a user opts out. The config itself is declared at `hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala:547` with no deprecation marker, and the path is still actively parameterised in tests (`TestSparkConsistentBucketClustering` at `:157`, `:190`, `:248`, `:326`).
   
   The real blocker here is the open question in the description - *"is it even required since we are going w/ new FG reader flow now?"* - which has not been answered. Until someone decides that, there is no code change to make. Suggest this ticket be resolved as a decision first (dev@ thread or a note from whoever owns HUDI-9107), and the deprecation mechanics tracked separately.
   
   Keeping this open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org