[GitHub] [airflow] andriisoldatenko commented on a change in pull request #5134: [AIRFLOW-4159] Add support for additional static labels for kubernetes

[GitBox <gi...@apache.org>]

andriisoldatenko commented on a change in pull request #5134: [AIRFLOW-4159] Add support for additional static labels for kubernetes
URL: https://github.com/apache/airflow/pull/5134#discussion_r279388048
 
 

 ##########
 File path: tests/contrib/executors/test_kubernetes_executor.py
 ##########
 @@ -627,6 +628,13 @@ def test_get_configmaps(self):
         configmaps = worker_config._get_configmaps()
         self.assertListEqual(['configmap_a', 'configmap_b'], configmaps)
 
+    def test_get_labels(self):
+        worker_config = WorkerConfiguration(self.kube_config)
+        labels = worker_config._get_labels({
+            'dag_id': 'dag_id',
+        })
+        self.assertEqual({'my_label': 'label_id', 'dag_id': 'dag_id'}, labels)
 
 Review comment:
   @ashb what do you mean? `my_label` is dynamic label, `dag_id` is static one.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services