You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/03/31 11:08:02 UTC
svn commit: r1670287 -
/tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
Author: markt
Date: Tue Mar 31 09:08:01 2015
New Revision: 1670287
URL: http://svn.apache.org/r1670287
Log:
Remove unnecessary code
Modified:
tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
Modified: tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java?rev=1670287&r1=1670286&r2=1670287&view=diff
==============================================================================
--- tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java (original)
+++ tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java Tue Mar 31 09:08:01 2015
@@ -35,10 +35,6 @@ import javax.servlet.jsp.PageContext;
*/
public class ScopedAttributeELResolver extends ELResolver {
- public ScopedAttributeELResolver() {
- super();
- }
-
@Override
public Object getValue(ELContext context, Object base, Object property) {
if (context == null) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1670287 - /tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
Posted by Mark Thomas <ma...@apache.org>.
On 31/03/2015 11:48, Konstantin Kolinko wrote:
> This is a javax.servlet.* class. I wonder whether this changes class signature.
My expectation was that the default constructor added by the compiler
would take care of it. Clirr agrees with that view.
> Oracle Javadoc lists a constructor,
> http://docs.oracle.com/javaee/6/api/javax/servlet/jsp/el/ScopedAttributeELResolver.html
If we had some meaningful Javadoc for the constructor that might be a
reason for restoring it.
For now, I'm happy with removing it.
Mark
>
>
> 2015-03-31 12:08 GMT+03:00 <ma...@apache.org>:
>> Author: markt
>> Date: Tue Mar 31 09:08:01 2015
>> New Revision: 1670287
>>
>> URL: http://svn.apache.org/r1670287
>> Log:
>> Remove unnecessary code
>>
>> Modified:
>> tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
>>
>> Modified: tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
>> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java?rev=1670287&r1=1670286&r2=1670287&view=diff
>> ==============================================================================
>> --- tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java (original)
>> +++ tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java Tue Mar 31 09:08:01 2015
>> @@ -35,10 +35,6 @@ import javax.servlet.jsp.PageContext;
>> */
>> public class ScopedAttributeELResolver extends ELResolver {
>>
>> - public ScopedAttributeELResolver() {
>> - super();
>> - }
>> -
>> @Override
>> public Object getValue(ELContext context, Object base, Object property) {
>> if (context == null) {
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1670287 - /tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
This is a javax.servlet.* class. I wonder whether this changes class signature.
Oracle Javadoc lists a constructor,
http://docs.oracle.com/javaee/6/api/javax/servlet/jsp/el/ScopedAttributeELResolver.html
2015-03-31 12:08 GMT+03:00 <ma...@apache.org>:
> Author: markt
> Date: Tue Mar 31 09:08:01 2015
> New Revision: 1670287
>
> URL: http://svn.apache.org/r1670287
> Log:
> Remove unnecessary code
>
> Modified:
> tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
>
> Modified: tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java?rev=1670287&r1=1670286&r2=1670287&view=diff
> ==============================================================================
> --- tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java (original)
> +++ tomcat/trunk/java/javax/servlet/jsp/el/ScopedAttributeELResolver.java Tue Mar 31 09:08:01 2015
> @@ -35,10 +35,6 @@ import javax.servlet.jsp.PageContext;
> */
> public class ScopedAttributeELResolver extends ELResolver {
>
> - public ScopedAttributeELResolver() {
> - super();
> - }
> -
> @Override
> public Object getValue(ELContext context, Object base, Object property) {
> if (context == null) {
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org