You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "christinadionysio (via GitHub)" <gi...@apache.org> on 2026/10/12 09:10:10 UTC
[PR] [SYSTEMDS-3978] Add Algebra Rules to Scuro [systemds]
christinadionysio opened a new pull request, #2621:
URL: https://github.com/apache/systemds/pull/2621
This patch adds rules for the DARE-Algebra to Scuro that enable better node sharing, and ordering.
Assisted-by: AI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3978] Add Algebra Rules to Scuro [systemds]
Posted by "christinadionysio (via GitHub)" <gi...@apache.org>.
christinadionysio merged PR #2621:
URL: https://github.com/apache/systemds/pull/2621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SYSTEMDS-3978] Add Algebra Rules to Scuro [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2621:
URL: https://github.com/apache/systemds/pull/2621#issuecomment-6123416271
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2621?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.62706%` with `142 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 76.68%. Comparing base ([`80817a9`](https://app.codecov.io/gh/apache/systemds/commit/80817a91a06c7cb82e92221e68a35fbb7d91f305?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`42426bf`](https://app.codecov.io/gh/apache/systemds/commit/42426bfb9e4fd9eec5061623ec97a208a4074b2b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/systemds/pull/2621?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [.../python/systemds/scuro/representations/openface.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Frepresentations%2Fopenface.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL3JlcHJlc2VudGF0aW9ucy9vcGVuZmFjZS5weQ==) | 11.59% | [61 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...on/systemds/scuro/drsearch/hyperparameter\_tuner.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Fhyperparameter_tuner.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL2h5cGVycGFyYW1ldGVyX3R1bmVyLnB5) | 66.21% | [25 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [src/main/python/systemds/scuro/drsearch/algebra.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Falgebra.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL2FsZ2VicmEucHk=) | 97.09% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../systemds/scuro/drsearch/modality\_shared\_memory.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Fmodality_shared_memory.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL21vZGFsaXR5X3NoYXJlZF9tZW1vcnkucHk=) | 52.94% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...systemds/scuro/drsearch/multimodal\_ga\_optimizer.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Fmultimodal_ga_optimizer.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL211bHRpbW9kYWxfZ2Ffb3B0aW1pemVyLnB5) | 94.06% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...python/systemds/scuro/representations/aggregate.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Frepresentations%2Faggregate.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL3JlcHJlc2VudGF0aW9ucy9hZ2dyZWdhdGUucHk=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...in/python/systemds/scuro/drsearch/node\_executor.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Fnode_executor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL25vZGVfZXhlY3V0b3IucHk=) | 61.53% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/python/systemds/scuro/drsearch/node\_scheduler.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Fnode_scheduler.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL25vZGVfc2NoZWR1bGVyLnB5) | 88.88% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...python/tests/scuro/test\_multimodal\_ga\_optimizer.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Ftests%2Fscuro%2Ftest_multimodal_ga_optimizer.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3Rlc3RzL3NjdXJvL3Rlc3RfbXVsdGltb2RhbF9nYV9vcHRpbWl6ZXIucHk=) | 95.34% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...on/systemds/scuro/drsearch/multimodal\_optimizer.py](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&filepath=src%2Fmain%2Fpython%2Fsystemds%2Fscuro%2Fdrsearch%2Fmultimodal_optimizer.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL21haW4vcHl0aG9uL3N5c3RlbWRzL3NjdXJvL2Ryc2VhcmNoL211bHRpbW9kYWxfb3B0aW1pemVyLnB5) | 96.55% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/systemds/pull/2621?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2621 +/- ##
==========================================
+ Coverage 74.27% 76.68% +2.41%
==========================================
Files 437 452 +15
Lines 26568 28066 +1498
==========================================
+ Hits 19733 21523 +1790
+ Misses 6835 6543 -292
```
| [Flag](https://app.codecov.io/gh/apache/systemds/pull/2621/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/systemds/pull/2621/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.68% <90.62%> (+2.41%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/systemds/pull/2621?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org