[GitHub] [spark] MaxGekk commented on a diff in pull request #41889: [SPARK-44328][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2325-2328]

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #41889:
URL: https://github.com/apache/spark/pull/41889#discussion_r1255906938


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1674,6 +1674,38 @@
       "Function <funcName> does not implement ScalarFunction or AggregateFunction."
     ]
   },
+  "INVALID_UPDATE_FIELD" : {
+    "message" : [
+      "Cannot update <table> field <fieldName> type:"
+    ],
+    "subClass" : {
+      "ARRAY_TYPE_UNSUPPORTED" : {

Review Comment:
   Let's make sub-class names shorter like `ARRAY_TYPE`. In any case, users will observe `CANNOT_UPDATE_FIELD .ARRAY_TYPE`



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -1674,6 +1674,38 @@
       "Function <funcName> does not implement ScalarFunction or AggregateFunction."
     ]
   },
+  "INVALID_UPDATE_FIELD" : {

Review Comment:
   Sorry, invalid FIELD or UPDATE? How about `CANNOT_UPDATE_FIELD`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org