You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/02/03 22:17:38 UTC

[GitHub] [incubator-mxnet] r3stl355 opened a new pull request #19833: [BUGFIX] fix #18938

r3stl355 opened a new pull request #19833:
URL: https://github.com/apache/incubator-mxnet/pull/19833


   ## Description ##
   BFix for https://github.com/apache/incubator-mxnet/issues/18938
   
   ## Checklist ##
   ### Essentials ###
   - [ x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x ] Changes are complete (i.e. I finished coding on this PR)
   - [x ] All changes have test coverage
   - [x ] Code is well-documented
   
   ### Changes ###
   Return early if zero-sized dimension is used. Added test to `test_operator.py`
   
   ## Comments ##
   One caveat - for the solution to work NumPy shape semantics must be used as shown in the test, otherwise the shape's zero-sized dimension of the output gets converted to 'unknown' dimension in the call to `[src.common.utils.h]::ConvertToNumpyShape` which in turn will throw an error about unknown shape. I think it's alright to use NumPy shape semantics because the input is using NumPy semantics but if not then this will require a much bigger fix.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19833: [BUGFIX] fix #18938, #18939, #18940

Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19833:
URL: https://github.com/apache/incubator-mxnet/pull/19833#issuecomment-774645780


   Added fixes for https://github.com/apache/incubator-mxnet/issues/18939 and https://github.com/apache/incubator-mxnet/issues/18940 as they are very similar


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #19833: [BUGFIX] fix #18938, #18939, #18940

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19833:
URL: https://github.com/apache/incubator-mxnet/pull/19833


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19833: [BUGFIX] fix #18938

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19833:
URL: https://github.com/apache/incubator-mxnet/pull/19833#issuecomment-774153621


   Jenkins CI successfully triggered : [unix-cpu, miscellaneous]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] r3stl355 commented on pull request #19833: [BUGFIX] fix #18938

Posted by GitBox <gi...@apache.org>.
r3stl355 commented on pull request #19833:
URL: https://github.com/apache/incubator-mxnet/pull/19833#issuecomment-774153565


   @mxnet-bot run ci [unix-cpu, miscellaneous]
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19833: [BUGFIX] fix #18938

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19833:
URL: https://github.com/apache/incubator-mxnet/pull/19833#issuecomment-772864418


   Hey @r3stl355 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, windows-gpu, sanity, miscellaneous, centos-cpu, centos-gpu, unix-gpu, website, unix-cpu, edge, windows-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org