You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Jason Lowe (JIRA)" <ji...@apache.org> on 2012/07/18 21:59:34 UTC
[jira] [Created] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Jason Lowe created MAPREDUCE-4455:
-------------------------------------
Summary: RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
Key: MAPREDUCE-4455
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: mrv2, resourcemanager
Reporter: Jason Lowe
Priority: Minor
TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4455:
-------------------------------------
Status: Patch Available (was: Open)
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4455:
-------------------------------------
Attachment: MAPREDUCE-4455-YARN-trunk-v3.patch
Thanks sid for your comments yesterday.
Updated the patch with drain dispatcher and removed the sleep
Thanks,
Mayank
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v3.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427759#comment-13427759 ]
Mayank Bansal commented on MAPREDUCE-4455:
------------------------------------------
These find bug warnings are already addressed in
MAPREDUCE-4452
Thanks,
Mayank
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Fix For: trunk
>
> Attachments: MAPREDUCE-4455-trunk-v1.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Siddharth Seth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-4455:
--------------------------------------
Fix Version/s: (was: trunk)
Target Version/s: 2.2.0-alpha
Status: Open (was: Patch Available)
Mayank, these transitions don't seem to be valid. I got this wrong while talking to you about this earlier... sorry about that.
The unit test is broken in this case. The InlineDispatcher, which is used for this test and others, behaves differently from the regular dispatcher. It handles all events inline, as against handling one event to completion before processing the next one.
For this test - the App should have transitioned to the KILLED state, before the ATTEMPT_KILLED event came in.
The DrainDispatcher seems like a much better option for unit tests.
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417628#comment-13417628 ]
Jason Lowe commented on MAPREDUCE-4455:
---------------------------------------
Output from the test:
{noformat}
2012-07-18 19:30:15,528 INFO [main] rmapp.TestRMAppTransitions (TestRMAppTransitions.java:testAppSubmittedKill(363)) - --- START: testAppSubmittedKill---
2012-07-18 19:30:15,768 INFO [main] resourcetracker.InlineDispatcher (InlineDispatcher.java:dispatch(38)) - Dispatching the event org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptEvent.EventType: START
2012-07-18 19:30:15,768 INFO [main] rmapp.RMAppImpl (RMAppImpl.java:handle(499)) - application_1342639815540_0001 State change from NEW to SUBMITTED
2012-07-18 19:30:15,769 INFO [main] rmapp.RMAppImpl (RMAppImpl.java:handle(499)) - application_1342639815540_0001 State change from SUBMITTED to ACCEPTED
2012-07-18 19:30:15,769 INFO [main] resourcetracker.InlineDispatcher (InlineDispatcher.java:dispatch(38)) - Dispatching the event org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptEvent.EventType: KILL
2012-07-18 19:30:15,770 INFO [main] resourcetracker.InlineDispatcher (InlineDispatcher.java:dispatch(38)) - Dispatching the event org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppFailedAttemptEvent.EventType: ATTEMPT_KILLED
2012-07-18 19:30:15,773 ERROR [main] rmapp.RMAppImpl (RMAppImpl.java:handle(494)) - Can't handle this event at current state
org.apache.hadoop.yarn.state.InvalidStateTransitonException: Invalid event: ATTEMPT_KILLED at ACCEPTED
at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:301)
at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43)
at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:443)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl.handle(RMAppImpl.java:492)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl.handle(RMAppImpl.java:70)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationEventDispatcher.handle(TestRMAppTransitions.java:103)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationEventDispatcher.handle(TestRMAppTransitions.java:89)
at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher.dispatch(InlineDispatcher.java:43)
at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher$TestEventHandler.handle(InlineDispatcher.java:33)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl$BaseFinalTransition.transition(RMAppAttemptImpl.java:701)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl$BaseFinalTransition.transition(RMAppAttemptImpl.java:651)
at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:357)
at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:298)
at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43)
at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:443)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.handle(RMAppAttemptImpl.java:485)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.handle(RMAppAttemptImpl.java:80)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationAttemptEventDispatcher.handle(TestRMAppTransitions.java:79)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions$TestApplicationAttemptEventDispatcher.handle(TestRMAppTransitions.java:65)
at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher.dispatch(InlineDispatcher.java:43)
at org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.InlineDispatcher$TestEventHandler.handle(InlineDispatcher.java:33)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl$KillAppAndAttemptTransition.transition(RMAppImpl.java:563)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl$KillAppAndAttemptTransition.transition(RMAppImpl.java:559)
at org.apache.hadoop.yarn.state.StateMachineFactory$SingleInternalArc.doTransition(StateMachineFactory.java:357)
at org.apache.hadoop.yarn.state.StateMachineFactory.doTransition(StateMachineFactory.java:298)
at org.apache.hadoop.yarn.state.StateMachineFactory.access$300(StateMachineFactory.java:43)
at org.apache.hadoop.yarn.state.StateMachineFactory$InternalStateMachine.doTransition(StateMachineFactory.java:443)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl.handle(RMAppImpl.java:492)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl.handle(RMAppImpl.java:70)
at org.apache.hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions.testAppSubmittedKill(TestRMAppTransitions.java:369)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:228)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
{noformat}
It would be nice if the state machine transition tests would fail on any invalid state transition encountered during the tests so these can be caught more proactively in the future.
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Priority: Minor
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal reassigned MAPREDUCE-4455:
----------------------------------------
Assignee: Mayank Bansal
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4455:
-------------------------------------
Attachment: MAPREDUCE-4455-trunk-v2.patch
Thanks sid for your review comments. I incorporated those in latest patch.
Thanks,
Mayank
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427748#comment-13427748 ]
Hadoop QA commented on MAPREDUCE-4455:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538971/MAPREDUCE-4455-trunk-v1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to introduce 4 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2701//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2701//console
This message is automatically generated.
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Fix For: trunk
>
> Attachments: MAPREDUCE-4455-trunk-v1.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427717#comment-13427717 ]
Mayank Bansal commented on MAPREDUCE-4455:
------------------------------------------
I think the issue is SUBMITTED And ACCEPTED APP transitions does not support for ATTEMPT_KILLED which is actuall being sent when KILL event is dispatched. Adding those two events.
Thanks,
Mayank
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4455:
-------------------------------------
Attachment: MAPREDUCE-4455-YARN-trunk-v2.patch
ATtaching another patch with new file structure. I think we need to move this JIRA to YARN as well.
Thanks,
Mayank
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v2.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4455:
-------------------------------------
Attachment: MAPREDUCE-4455-trunk-v1.patch
Fixing the issue and test cases.
Thanks,
Mayank
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Fix For: trunk
>
> Attachments: MAPREDUCE-4455-trunk-v1.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435483#comment-13435483 ]
Hadoop QA commented on MAPREDUCE-4455:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541112/MAPREDUCE-4455-YARN-trunk-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2738//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2738//console
This message is automatically generated.
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v2.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4455) RMAppImpl state machine does not
handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Mayank Bansal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mayank Bansal updated MAPREDUCE-4455:
-------------------------------------
Fix Version/s: trunk
Status: Patch Available (was: Open)
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Fix For: trunk
>
> Attachments: MAPREDUCE-4455-trunk-v1.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434640#comment-13434640 ]
Hadoop QA commented on MAPREDUCE-4455:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540973/MAPREDUCE-4455-trunk-v2.patch
against trunk revision .
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2729//console
This message is automatically generated.
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4455) RMAppImpl state machine does
not handle event ATTEMPT_KILLED at ACCEPTED
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436249#comment-13436249 ]
Hadoop QA commented on MAPREDUCE-4455:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541263/MAPREDUCE-4455-YARN-trunk-v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2746//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2746//console
This message is automatically generated.
> RMAppImpl state machine does not handle event ATTEMPT_KILLED at ACCEPTED
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-4455
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4455
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, resourcemanager
> Reporter: Jason Lowe
> Assignee: Mayank Bansal
> Priority: Minor
> Attachments: MAPREDUCE-4455-trunk-v1.patch, MAPREDUCE-4455-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v2.patch, MAPREDUCE-4455-YARN-trunk-v3.patch
>
>
> TestRMAppTransitions#testAppSubmittedKilled causes an invalid event exception but the test doesn't catch the error since the final app state is still killed. Killed for the wrong reason, but the final state is the same.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira