You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/04 16:10:24 UTC

[GitHub] [kafka] C0urante opened a new pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

C0urante opened a new pull request #10630:
URL: https://github.com/apache/kafka/pull/10630


   Accidental logging of record contents is a security risk as they may contain sensitive information such as PII. This downgrades the level of log messages in the `WorkerSourceTask` class that contain raw record contents to `TRACE` level in order to make that scenario less likely.
   
   As these changes are trivial no tests are added.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley merged pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

Posted by GitBox <gi...@apache.org>.
tombentley merged pull request #10630:
URL: https://github.com/apache/kafka/pull/10630


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10630:
URL: https://github.com/apache/kafka/pull/10630#issuecomment-832062862


   @rhauch @tombentley could you please review at your earliest convenience?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10630:
URL: https://github.com/apache/kafka/pull/10630#issuecomment-832831207


   Thanks @tombentley--good point, I agree that the record content is probably not necessary there and think it's safest to remove the record content from the message. I've altered it to reference only the topic and partition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] tombentley commented on pull request #10630: MINOR: Stop logging raw record contents above TRACE level in WorkerSourceTask

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #10630:
URL: https://github.com/apache/kafka/pull/10630#issuecomment-833358254


   Thanks @C0urante!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org