You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by cramja <gi...@git.apache.org> on 2017/03/04 15:29:35 UTC
[GitHub] incubator-quickstep pull request #205: simplify logic of download script
GitHub user cramja opened a pull request:
https://github.com/apache/incubator-quickstep/pull/205
simplify logic of download script
In prep for RC6, @zuyu recommended making a small change to the patch script.
Now it should be explicit as to exactly what files are being patched.
Post-patch example output
```bash
...
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/linenoise/linenoise.h
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/linenoise/linenoise.c
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/gflags/CMakeLists.txt
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/gflags/src/gflags_reporting.cc
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/re2/CMakeLists.txt
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/benchmark/CMakeLists.txt
patching file /Users/cramja/workspace/quickstep/incubator-quickstep/third_party/src/benchmark/src/CMakeLists.txt
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cramja/incubator-quickstep cleanup-download-scripts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/205.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #205
----
commit 2e7f446bdcb6f6f065e93befcf8c7b3d437cc4c4
Author: cramja <ma...@gmail.com>
Date: 2017-03-04T15:28:03Z
simplify logic of download script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep pull request #205: simplify logic of download script
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/205
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-quickstep issue #205: simplify logic of download script
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/205
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---