You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "crossoverJie (via GitHub)" <gi...@apache.org> on 2024/03/01 16:40:56 UTC
[PR] [Improve] Add optional parameters for getPartitionedStats [pulsar-client-go]
crossoverJie opened a new pull request, #1193:
URL: https://github.com/apache/pulsar-client-go/pull/1193
### Motivation
To keep consistent with the Java client.
Releted PR: https://github.com/apache/pulsar/pull/21611
### Modifications
Add `GetStatsOptions` params.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (yes)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (GoDocs)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Add optional parameters for getPartitionedStats [pulsar-client-go]
Posted by "crossoverJie (via GitHub)" <gi...@apache.org>.
crossoverJie commented on PR #1193:
URL: https://github.com/apache/pulsar-client-go/pull/1193#issuecomment-1978018357
> Can you add some test cases like[ `testPartitionState` and `testNonPartitionState`](https://github.com/apache/pulsar/pull/21611/files#diff-5b72f9d71e1902b986d613bc684b04b26a89ece305ae0329e9f014605ef85edb)?
I've added, but find that there's a test [overtime](https://github.com/crossoverJie/pulsar-client-go/actions/runs/8149980067/job/22275484467?pr=9) after upgrading the image to `3.2.0`, and I can adjust the sequence to work properly, but this may be a potential bug, I'll try to locate to specific reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improve] Add optional parameters for getPartitionedStats [pulsar-client-go]
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie merged PR #1193:
URL: https://github.com/apache/pulsar-client-go/pull/1193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org