You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by da...@apache.org on 2013/05/13 14:32:23 UTC

svn commit: r1481821 - /subversion/branches/1.7.x/STATUS

Author: danielsh
Date: Mon May 13 12:32:22 2013
New Revision: 1481821

URL: http://svn.apache.org/r1481821
Log:
Vote.

Modified:
    subversion/branches/1.7.x/STATUS

Modified: subversion/branches/1.7.x/STATUS
URL: http://svn.apache.org/viewvc/subversion/branches/1.7.x/STATUS?rev=1481821&r1=1481820&r2=1481821&view=diff
==============================================================================
--- subversion/branches/1.7.x/STATUS (original)
+++ subversion/branches/1.7.x/STATUS Mon May 13 12:32:22 2013
@@ -228,21 +228,12 @@ Candidate changes:
      in this subthread: http://svn.haxx.se/dev/archive-2013-04/0056.shtml
      This issue can be exploited by people with commit access to corrupt
      an FSFS repository, and has been assigned a CVE number: CVE-2013-1968
-     r1481627 addresses concerns raised by danielsh below.
+     r1481627 addresses concerns raised by danielsh.
    Branch:
      ^/subversion/branches/1.7.x-issue4340
    Votes:
-     +1: stsp
+     +1: stsp, danielsh
      +1: cmpilato (without r1481627)
-     -0: danielsh (escape_newline() should escape any control character,
-                   not just '\n'; svn_stringbuf_ensure() call should have
-                   "+5", not "+4", in its last argument; suggest to simplify
-                   escape_newline() to
-                   for (c = path; *c; c++)
-                     (0<c<0x20) ? svn_stringbuf_appendbytes("\\%03o" % c)
-                                : svn_stringbuf_appendbyte(c);
-                   that avoids memory bugs and is sufficient for an error path.
-                   +1 once the +4->+5 thing is addressed.)
 
  * r1461760
    Additional fix related to issue #4340, "filenames containing \n corrupt