You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/25 09:54:33 UTC
[GitHub] [camel] mcollovati opened a new pull request #4509: [CAMEL-15748] nullify mqtt client on producer and consumer stop
mcollovati opened a new pull request #4509:
URL: https://github.com/apache/camel/pull/4509
When restarting a route with a paho consumer or using a paho producer
after a connection failure to the broker the mqtt client was not
reconnected. This patch sets consumer and producer internl mqtt client
instance to null os stop, so that a restart will create a new instance
and connect to the broker again.
- [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line and body.
- [X] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
- [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [X] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #4509: [CAMEL-15748] nullify mqtt client on producer and consumer stop
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4509:
URL: https://github.com/apache/camel/pull/4509#issuecomment-716168340
Wonder if you would mind creating a PR against master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a change in pull request #4509: [CAMEL-15748] nullify mqtt client on producer and consumer stop
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4509:
URL: https://github.com/apache/camel/pull/4509#discussion_r511602721
##########
File path: components/camel-paho/src/test/java/org/apache/camel/component/paho/PahoReconnectAfterFailureTest.java
##########
@@ -0,0 +1,128 @@
+package org.apache.camel.component.paho;
Review comment:
You need to add the ASF license header to the top of this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #4509: [CAMEL-15748] nullify mqtt client on producer and consumer stop
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4509:
URL: https://github.com/apache/camel/pull/4509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org