You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/04/15 11:09:19 UTC
[GitHub] [incubator-doris] xy720 commented on a change in pull request
#3191: [Optimize][Delete] Simplify the delete process to make it fast
xy720 commented on a change in pull request #3191: [Optimize][Delete] Simplify the delete process to make it fast
URL: https://github.com/apache/incubator-doris/pull/3191#discussion_r408761574
##########
File path: fe/src/main/java/org/apache/doris/load/DeleteHandler.java
##########
@@ -0,0 +1,549 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.load;
+
+import com.google.common.base.Joiner;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
+import org.apache.doris.analysis.BinaryPredicate;
+import org.apache.doris.analysis.DeleteStmt;
+import org.apache.doris.analysis.IsNullPredicate;
+import org.apache.doris.analysis.LiteralExpr;
+import org.apache.doris.analysis.Predicate;
+import org.apache.doris.analysis.SlotRef;
+import org.apache.doris.catalog.Catalog;
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.Database;
+import org.apache.doris.catalog.KeysType;
+import org.apache.doris.catalog.MaterializedIndex;
+import org.apache.doris.catalog.MaterializedIndex.IndexExtState;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Partition;
+import org.apache.doris.catalog.PartitionType;
+import org.apache.doris.catalog.Replica;
+import org.apache.doris.catalog.Table;
+import org.apache.doris.catalog.Tablet;
+import org.apache.doris.catalog.TabletInvertedIndex;
+import org.apache.doris.catalog.Type;
+import org.apache.doris.common.AnalysisException;
+import org.apache.doris.common.Config;
+import org.apache.doris.common.DdlException;
+import org.apache.doris.common.ErrorCode;
+import org.apache.doris.common.ErrorReport;
+import org.apache.doris.common.MarkedCountDownLatch;
+import org.apache.doris.common.UserException;
+import org.apache.doris.common.io.Writable;
+import org.apache.doris.common.util.ListComparator;
+import org.apache.doris.common.util.TimeUtils;
+import org.apache.doris.mysql.privilege.PrivPredicate;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.service.FrontendOptions;
+import org.apache.doris.task.AgentBatchTask;
+import org.apache.doris.task.AgentTaskExecutor;
+import org.apache.doris.task.AgentTaskQueue;
+import org.apache.doris.task.DeleteJob;
+import org.apache.doris.task.DeleteJob.DeleteState;
+import org.apache.doris.task.PushTask;
+import org.apache.doris.thrift.TPriority;
+import org.apache.doris.thrift.TPushType;
+import org.apache.doris.thrift.TTaskType;
+import org.apache.doris.transaction.GlobalTransactionMgr;
+import org.apache.doris.transaction.TabletCommitInfo;
+import org.apache.doris.transaction.TransactionState;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+
+import java.io.DataInput;
+import java.io.DataOutput;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.Map.Entry;
+import java.util.UUID;
+import java.util.concurrent.TimeUnit;
+
+public class DeleteHandler implements Writable {
+ private static final Logger LOG = LogManager.getLogger(DeleteHandler.class);
+
+ // TransactionId -> DeleteJob
+ private Map<Long, DeleteJob> idToDeleteJob;
+
+ // Db -> DeleteInfo list
+ private Map<Long, List<DeleteInfo>> dbToDeleteInfos;
+
+ public DeleteHandler() {
+ idToDeleteJob = Maps.newConcurrentMap();
+ dbToDeleteInfos = Maps.newConcurrentMap();
+ }
+
+ public void process(DeleteStmt stmt) throws DdlException {
+ String dbName = stmt.getDbName();
+ String tableName = stmt.getTableName();
+ String partitionName = stmt.getPartitionName();
+ List<Predicate> conditions = stmt.getDeleteConditions();
+ Database db = Catalog.getInstance().getDb(dbName);
+ if (db == null) {
+ throw new DdlException("Db does not exist. name: " + dbName);
+ }
+
+ DeleteJob deleteJob = null;
+ DeleteInfo deleteInfo = null;
+ long transactionId;
+ MarkedCountDownLatch<Long, Long> countDownLatch;
+ db.readLock();
+ try {
+ Table table = db.getTable(tableName);
+ if (table == null) {
+ throw new DdlException("Table does not exist. name: " + tableName);
+ }
+
+ if (table.getType() != Table.TableType.OLAP) {
+ throw new DdlException("Not olap type table. type: " + table.getType().name());
+ }
+ OlapTable olapTable = (OlapTable) table;
+
+ if (olapTable.getState() != OlapTable.OlapTableState.NORMAL) {
+ throw new DdlException("Table's state is not normal: " + tableName);
+ }
+
+ if (partitionName == null) {
+ if (olapTable.getPartitionInfo().getType() == PartitionType.RANGE) {
+ throw new DdlException("This is a range partitioned table."
+ + " You should specify partition in delete stmt");
+ } else {
+ // this is a unpartitioned table, use table name as partition name
+ partitionName = olapTable.getName();
+ }
+ }
+
+ Partition partition = olapTable.getPartition(partitionName);
+ if (partition == null) {
+ throw new DdlException("Partition does not exist. name: " + partitionName);
+ }
+
+ List<String> deleteConditions = Lists.newArrayList();
+
+ // pre check
+ checkDeleteV2(olapTable, partition, conditions, deleteConditions, true);
+
+ // generate label
+ String label = "delete_" + UUID.randomUUID();
+
+ // begin txn here and generate txn id
+ transactionId = Catalog.getCurrentGlobalTransactionMgr().beginTransaction(db.getId(),
+ Lists.newArrayList(table.getId()), label,"FE: " + FrontendOptions.getLocalHostAddress(),
+ TransactionState.LoadJobSourceType.FRONTEND, Config.stream_load_default_timeout_second);
+
+ deleteInfo = new DeleteInfo(db.getId(), olapTable.getId(), tableName,
+ partition.getId(), partitionName,
+ -1, 0, deleteConditions);
+ deleteJob = new DeleteJob(transactionId, deleteInfo);
+ idToDeleteJob.put(deleteJob.getTransactionId(), deleteJob);
+ Catalog.getCurrentGlobalTransactionMgr().getCallbackFactory().addCallback(deleteJob);
+ // task sent to be
+ AgentBatchTask batchTask = new AgentBatchTask();
+ // count total replica num
+ int totalReplicaNum = 0;
+ for (MaterializedIndex index : partition.getMaterializedIndices(IndexExtState.VISIBLE)) {
+ for (Tablet tablet : index.getTablets()) {
+ totalReplicaNum += tablet.getReplicas().size();
+ }
+ }
+ countDownLatch = new MarkedCountDownLatch<Long, Long>(totalReplicaNum);
+
+ for (MaterializedIndex index : partition.getMaterializedIndices(IndexExtState.VISIBLE)) {
+ long indexId = index.getId();
+ int schemaHash = olapTable.getSchemaHashByIndexId(indexId);
+
+ for (Tablet tablet : index.getTablets()) {
+ long tabletId = tablet.getId();
+
+ // set push type
+ TPushType type = TPushType.DELETE;
+
+ for (Replica replica : tablet.getReplicas()) {
+ long replicaId = replica.getId();
+ long backendId = replica.getBackendId();
+ countDownLatch.addMark(backendId, tabletId);
+
+ // create push task for each replica
+ PushTask pushTask = new PushTask(null,
+ replica.getBackendId(), db.getId(), olapTable.getId(),
+ partition.getId(), indexId,
+ tabletId, replicaId, schemaHash,
+ -1, 0, "", -1, 0,
+ -1, type, conditions,
+ true, TPriority.NORMAL,
+ TTaskType.REALTIME_PUSH,
+ transactionId,
+ Catalog.getCurrentGlobalTransactionMgr().getTransactionIDGenerator().getNextTransactionId());
+ pushTask.setIsSchemaChanging(true);
+ pushTask.setCountDownLatch(countDownLatch);
+
+ if (AgentTaskQueue.addTask(pushTask)) {
+ batchTask.addTask(pushTask);
+ deleteJob.addPushTask(pushTask);
+ deleteJob.addTablet(tabletId);
+ }
+ }
+ }
+ }
+
+ // submit push tasks
+ if (batchTask.getTaskNum() > 0) {
+ AgentTaskExecutor.submit(batchTask);
+ }
+
+ } catch (Throwable t) {
+ LOG.warn("error occurred during delete process", t);
+ throw new DdlException(t.getMessage(), t);
+ } finally {
+ db.readUnlock();
+ }
+
+ long timeoutMs = deleteJob.getTimeout();
+ LOG.info("waiting delete Job finish, signature: {}, timeout: {}", transactionId, timeoutMs);
+ boolean ok = false;
+ try {
+ ok = countDownLatch.await(timeoutMs, TimeUnit.MILLISECONDS);
+ } catch (InterruptedException e) {
+ LOG.warn("InterruptedException: ", e);
+ ok = false;
+ }
+
+ if (ok) {
+ commitJob(deleteJob, db, timeoutMs);
+ } else {
+ deleteJob.checkQuorum();
+ if (deleteJob.getState() != DeleteState.UN_QUORUM) {
+ long nowQuorumTimeMs = System.currentTimeMillis();
+ long endQuorumTimeoutMs = nowQuorumTimeMs + timeoutMs / 2;
+ // if job's state is finished or stay in quorum_finished for long time, try to commit it.
+ try {
+ while (deleteJob.getState() == DeleteState.QUORUM_FINISHED && endQuorumTimeoutMs > nowQuorumTimeMs) {
+ deleteJob.checkQuorum();
+ Thread.sleep(1000);
+ nowQuorumTimeMs = System.currentTimeMillis();
+ }
+ commitJob(deleteJob, db, timeoutMs);
+ } catch (InterruptedException e) {
+ }
+ } else {
+ List<Entry<Long, Long>> unfinishedMarks = countDownLatch.getLeftMarks();
+ // only show at most 5 results
+ List<Entry<Long, Long>> subList = unfinishedMarks.subList(0, Math.min(unfinishedMarks.size(), 5));
+ String errMsg = "Unfinished replicas:" + Joiner.on(", ").join(subList);
+ LOG.warn("delete job timeout: {}, {}", transactionId, errMsg);
+ cancelJob(deleteJob, "delete job timeout");
+ throw new DdlException("failed to delete replicas from job: {}, {}, transactionId, errMsg");
+ }
+ }
+ }
+
+ private void commitJob(DeleteJob job, Database db, long timeout) {
+ long transactionId = job.getTransactionId();
+ GlobalTransactionMgr globalTransactionMgr = Catalog.getCurrentGlobalTransactionMgr();
+ TransactionState transactionState = globalTransactionMgr.getTransactionState(transactionId);
+ List<TabletCommitInfo> tabletCommitInfos = new ArrayList<TabletCommitInfo>();
+ try {
+ TabletInvertedIndex invertedIndex = Catalog.getCurrentInvertedIndex();
+ for (TabletDeleteInfo tDeleteInfo : job.getTabletDeleteInfo()) {
+ for (Replica replica : tDeleteInfo.getFinishedReplicas()) {
+ // the inverted index contains rolling up replica
+ Long tabletId = invertedIndex.getTabletIdByReplica(replica.getId());
+ if (tabletId == null) {
+ LOG.warn("could not find tablet id for replica {}, the tablet maybe dropped", replica);
+ continue;
+ }
+ tabletCommitInfos.add(new TabletCommitInfo(tabletId, replica.getBackendId()));
+ }
+ }
+ boolean isSuccess = globalTransactionMgr.commitAndPublishTransaction(db, transactionId, tabletCommitInfos, timeout);
+ if (!isSuccess) {
+ cancelJob(job, "delete timeout when waiting transaction commit");
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org