You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2025/09/11 01:47:51 UTC
[PR] fix: address feedback from initial release [iceberg-cpp]
wgtmac opened a new pull request, #223:
URL: https://github.com/apache/iceberg-cpp/pull/223
- suppress warnings from verify_rc.sh
- fix release.sh not to rename artifacts
- refactor wordings in the email templates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: address feedback from initial release [iceberg-cpp]
Posted by "HeartLinked (via GitHub)" <gi...@apache.org>.
HeartLinked commented on code in PR #223:
URL: https://github.com/apache/iceberg-cpp/pull/223#discussion_r2338317522
##########
dev/release/release.sh:
##########
@@ -63,13 +63,6 @@ svn \
svn co "${dist_url}/${release_id}"
pushd "${release_id}"
-echo "Renaming artifacts to their final release names..."
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: address feedback from initial release [iceberg-cpp]
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #223:
URL: https://github.com/apache/iceberg-cpp/pull/223#discussion_r2338307434
##########
dev/release/release.sh:
##########
@@ -63,13 +63,6 @@ svn \
svn co "${dist_url}/${release_id}"
pushd "${release_id}"
-echo "Renaming artifacts to their final release names..."
Review Comment:
We don't need this hack any more. Now artifact names do not have `-rcN` suffix. @HeartLinked
cc @liurenjie1024
##########
dev/release/verify_rc.sh:
##########
@@ -118,9 +118,11 @@ test_source_distribution() {
# Configure build
cmake -S . -B build \
+ -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \
Review Comment:
I have added `--compile-no-warning-as-error` below and this one is also required. @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix: address feedback from initial release [iceberg-cpp]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #223:
URL: https://github.com/apache/iceberg-cpp/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org