You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/04 16:47:04 UTC

[GitHub] [superset] ofekisr commented on a change in pull request #16957: fix(filterset): failed to parse json_metadata json on creating new filterset

ofekisr commented on a change in pull request #16957:
URL: https://github.com/apache/superset/pull/16957#discussion_r721540788



##########
File path: superset/dashboards/filter_sets/schemas.py
##########
@@ -34,7 +34,7 @@ class JsonMetadataSchema(Schema):
 
 
 class FilterSetSchema(Schema):
-    json_metadata_schema: JsonMetadataSchema = JsonMetadataSchema()
+    json_metadata_schema: JsonMetadataSchema = JsonMetadataSchema(unknown=INCLUDE)

Review comment:
       it enforces the required field and helps what should be inside but still, it is ok to let other fields who used only by the front. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org