You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2020/10/19 14:01:42 UTC
[qpid-jms] branch master updated: NO-JIRA: fix now-obvious fault in
test from 55f0680a3c0c2ac2c8e8df51496873c16b60f2f8,
which never showed up locally once in lots of runs but did on the first go
in multiple CI envs/jobs
This is an automated email from the ASF dual-hosted git repository.
robbie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-jms.git
The following commit(s) were added to refs/heads/master by this push:
new 58df602 NO-JIRA: fix now-obvious fault in test from 55f0680a3c0c2ac2c8e8df51496873c16b60f2f8, which never showed up locally once in lots of runs but did on the first go in multiple CI envs/jobs
58df602 is described below
commit 58df602ab7cab0fe493434f317b7f7332610e73a
Author: Robbie Gemmell <ro...@apache.org>
AuthorDate: Mon Oct 19 14:59:28 2020 +0100
NO-JIRA: fix now-obvious fault in test from 55f0680a3c0c2ac2c8e8df51496873c16b60f2f8, which never showed up locally once in lots of runs but did on the first go in multiple CI envs/jobs
---
.../java/org/apache/qpid/jms/integration/ConsumerIntegrationTest.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConsumerIntegrationTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConsumerIntegrationTest.java
index cc1c8c1..e0e751c 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConsumerIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/ConsumerIntegrationTest.java
@@ -2393,8 +2393,6 @@ public class ConsumerIntegrationTest extends QpidJmsTestCase {
List<String> receivedPayloads = new ArrayList<>();
- MessageConsumer consumer = session.createConsumer(destination);
-
// Await the messages being prefetched before we set the listener to make the
// test viable, ongoing prefetching would make the reordering non-deterministic.
((JmsConnection) connection).addConnectionListener(new JmsDefaultConnectionListener() {
@@ -2404,6 +2402,8 @@ public class ConsumerIntegrationTest extends QpidJmsTestCase {
}
});
+ MessageConsumer consumer = session.createConsumer(destination);
+
boolean awaitPrefetch = arrived.await(15, TimeUnit.SECONDS);
assertTrue("Messages not prefetched within given timeout, outstanding: " + arrived.getCount(), awaitPrefetch);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org