You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "cbornet (via GitHub)" <gi...@apache.org> on 2023/05/30 20:55:52 UTC
[GitHub] [pulsar] cbornet opened a new pull request, #20441: [cleanup][build] Remove docker build and publish scripts
cbornet opened a new pull request, #20441:
URL: https://github.com/apache/pulsar/pull/20441
### Motivation
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
Those scripts are not used anymore in the release process
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [x] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #20441: [cleanup][build] Remove docker build and publish scripts
Posted by "cbornet (via GitHub)" <gi...@apache.org>.
cbornet commented on PR #20441:
URL: https://github.com/apache/pulsar/pull/20441#issuecomment-1573204710
Closing this one as we will update the scripts instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #20441: [cleanup][build] Remove docker build and publish scripts
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20441:
URL: https://github.com/apache/pulsar/pull/20441#issuecomment-1573235930
See #20462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #20441: [cleanup][build] Remove docker build and publish scripts
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #20441:
URL: https://github.com/apache/pulsar/pull/20441#issuecomment-1570265110
> I suggest that we should update the build and publish scripts instead of removing them.
+1. In addition, it is necessary to handle existing maintenance branches. Otherwise, the "latest" tag will always point to the image that was published last. That should be prevented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20441: [cleanup][build] Remove docker build and publish scripts
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20441:
URL: https://github.com/apache/pulsar/pull/20441#issuecomment-1569370698
@cbornet Thanks for your contribution! As you mark this PR as doc-complete, can you share the related doc page or change set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #20441: [cleanup][build] Remove docker build and publish scripts
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20441:
URL: https://github.com/apache/pulsar/pull/20441#issuecomment-1570255078
I suggest that we should update the build and publish scripts instead of removing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet closed pull request #20441: [cleanup][build] Remove docker build and publish scripts
Posted by "cbornet (via GitHub)" <gi...@apache.org>.
cbornet closed pull request #20441: [cleanup][build] Remove docker build and publish scripts
URL: https://github.com/apache/pulsar/pull/20441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org