You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/10/07 17:32:51 UTC
[GitHub] [camel-quarkus] ppalaga opened a new issue #3167: AWS S3 tests should delete all buckets they create
ppalaga opened a new issue #3167:
URL: https://github.com/apache/camel-quarkus/issues/3167
This does not matter much as long as testing against Localstack, but may hurt when testing against real AWS. All long living resources may cause costs to the AWS account owner.
I found (potential) resource leaks in following tests:
* `org.apache.camel.quarkus.component.aws2.Aws2S3Test.copyObject()` the bucket is created implicitly via `Aws2S3Resource.objectKey(String)` passing `autoCreateBucket=true` This bucked needs to be deleted at the and of the test. Even better `org.apache.camel.quarkus.component.aws2.Aws2S3Test.getAllObjects(String)` should be renamed to `autoCreateBucket()` so that future user maintainers see its main effect clearly and because it is not used for anything else.
* `org.apache.camel.quarkus.component.aws2.Aws2S3Resource.upload(String, String)` should not need `autoCreateBucket=true` because it uses the bucked created (and also deleted) in Aws2S3TestEnvCustomizer.
* Ideally, all tests creating buckets (`deleteBucket()` and `copyObject()`) should use some sort of try-finally to delete the buckets even if something unexpected happens during the test.
I have not inspected other modules under `integration-test-groups/aws2` so similar leaks may exist there too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga closed issue #3167: AWS S3 tests should delete all buckets they create
Posted by GitBox <gi...@apache.org>.
ppalaga closed issue #3167:
URL: https://github.com/apache/camel-quarkus/issues/3167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga closed issue #3167: AWS S3 tests should delete all buckets they create
Posted by GitBox <gi...@apache.org>.
ppalaga closed issue #3167:
URL: https://github.com/apache/camel-quarkus/issues/3167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org