You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/07/31 12:58:57 UTC

[GitHub] [tomee] sultan opened a new pull request, #907: TOMEE-4023 Comparison pages with wrong specs per profile

sultan opened a new pull request, #907:
URL: https://github.com/apache/tomee/pull/907

   Tomcat does not include JSTL nor the javax.security.enterprise.* packages. These can be moved to WebProfile.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] rzo1 commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229244493

   I just did the reverts as suggested by @dblevins 
   
   Perhaps, it would be good to move this discussion towards the dev@ list, so we get consensus of what we want to display in our docs?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] dblevins commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
dblevins commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229347207

   @sultan you're right -- looks like they're not shipping it and we have a shaded version of that jar as it isn't even converted to the jakarta namespace.  Also looks like I got JASPIC and Jakarta Security mixed up.
   
   @rzo1 sorry for the busywork


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] rzo1 commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229232110

   Thanks @sultan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] rzo1 commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229243140

   > We should probably revert this change.
   
   @dblevins Missed that. I will do the reverts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] sultan commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
sultan commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229243766

   the tomcat website indeed provides implementation for JSTL, but its not included in the tomcat server release itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] rzo1 commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229386178

   @dblevins no problem.
   
   How do we want to proceed? Looks like the changes are valid (but maybe not clear enough?) and we have a lot of confusion around it. So it can only improve :)
   
   - (A) We recreate the PRs + the PR in site generator, ask for review on the list and move on an after some time
   - (B) We recreate the PRs + the PR in site generator and move on 
   - (C) Revert the revert, i.e. cherry pick the commit from the squash merge and move on
   
   In terms of a clear git history, I would prefer (A) or (B) but we can also do (C), if this is less effort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] dblevins commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
dblevins commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229233093

   Sorry all for not seeing this PR sooner.  Here's information on Tomcat's JSTL and JASPIC implementations:
   
    - https://tomcat.apache.org/taglibs.html
    - https://tomcat.apache.org/tomcat-9.0-doc/config/jaspic.html
   
   We should probably revert this change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] rzo1 merged pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
rzo1 merged PR #907:
URL: https://github.com/apache/tomee/pull/907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee] sultan commented on pull request #907: TOMEE-4023 Comparison pages with wrong specs per profile

Posted by GitBox <gi...@apache.org>.
sultan commented on PR #907:
URL: https://github.com/apache/tomee/pull/907#issuecomment-1229429490

   i think i wrongly moved debugging support out of tomcat into webprofile spec. so i made some minor changes that will require me to make the PRs again. i can take advantage of the new PRs to add some text to about tomcat not shipped with JSTL nor security api packages


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org