You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by jun aoki <ju...@gmail.com> on 2016/04/14 04:19:19 UTC
Review Request 46186: Changing HAWQ Ports through Ambari prevents HAWQ
service from restarting
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852
Repository: ambari
Description
-------
HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
This change is to make Ambari to look for an older port value.
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
Diff: https://reviews.apache.org/r/46186/diff/
Testing
-------
Unit test has passed.
Manual Test in progress.
Thanks,
jun aoki
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
> On April 14, 2016, 3:33 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py, line 92
> > <https://reviews.apache.org/r/46186/diff/1/?file=1343689#file1343689line92>
> >
> > I think this function should only take a name of component and use utility to get process name and port number based on metadata. Maybe refactor that function from status into utils ?
PROCESS_INFO(now renamed to COMPONENT_ATTRIBUTES) holds port property names but not port numbers themselve. And a old port and a new port can be different depending on where it is from (either from Ambari or local hawq-site.xml)
The source can be determined by action(whether it is start or stop). so here is too much dependencies. This function should only form a string of netstat so I'd rather not to have the logic.
(I'd replace the if statement with PROCESS_INFO though)
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128826
-----------------------------------------------------------
On April 14, 2016, 2:19 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:19 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128826
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 92)
<https://reviews.apache.org/r/46186/#comment192278>
I think this function should only take a name of component and use utility to get process name and port number based on metadata. Maybe refactor that function from status into utils ?
- Alexander Denissov
On April 14, 2016, 2:19 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:19 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128950
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 96)
<https://reviews.apache.org/r/46186/#comment192403>
will fix
- jun aoki
On April 14, 2016, 2:19 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:19 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128934
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py (line 25)
<https://reviews.apache.org/r/46186/#comment192381>
that's a good idea Matt.
- jun aoki
On April 14, 2016, 2:19 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:19 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
-----------------------------------------------------------
(Updated April 15, 2016, midnight)
Review request for Ambari.
Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852
Repository: ambari
Description
-------
HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
This change is to make Ambari to look for an older port value.
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py PRE-CREATION
Diff: https://reviews.apache.org/r/46186/diff/
Testing (updated)
-------
Unit test has passed.
----------------------------------------------------------------------
Ran 277 tests in 8.851s
OK
----------------------------------------------------------------------
Total run:957
Total errors:0
Total failures:0
OK
Manual Test in progress.
Thanks,
jun aoki
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
-----------------------------------------------------------
(Updated April 14, 2016, 11:59 p.m.)
Review request for Ambari.
Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852
Repository: ambari
Description
-------
HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
This change is to make Ambari to look for an older port value.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
ambari-server/src/test/python/stacks/2.3/HAWQ/test_utils.py PRE-CREATION
Diff: https://reviews.apache.org/r/46186/diff/
Testing
-------
Unit test has passed.
Manual Test in progress.
Thanks,
jun aoki
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128998
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 14, 2016, 9:20 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 9:20 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
> On April 14, 2016, 11 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py, line 26
> > <https://reviews.apache.org/r/46186/diff/3/?file=1345552#file1345552line26>
> >
> > do we need unit test for this function ?
will add unit test.
> On April 14, 2016, 11 p.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py, line 46
> > <https://reviews.apache.org/r/46186/diff/1-3/?file=1343693#file1343693line46>
> >
> > variable is not used anywhere else other than the line below, can probably inline it for brevity
will do
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129024
-----------------------------------------------------------
On April 14, 2016, 9:20 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 9:20 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129024
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py (line 31)
<https://reviews.apache.org/r/46186/#comment192489>
variable is not used anywhere else other than the line below, can probably inline it for brevity
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py (line 26)
<https://reviews.apache.org/r/46186/#comment192490>
do we need unit test for this function ?
- Alexander Denissov
On April 14, 2016, 9:20 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 9:20 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129018
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On April 14, 2016, 9:20 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 9:20 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review129025
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Denissov
On April 14, 2016, 9:20 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 9:20 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
-----------------------------------------------------------
(Updated April 14, 2016, 9:20 p.m.)
Review request for Ambari.
Changes
-------
Added missing import.
Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852
Repository: ambari
Description
-------
HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
This change is to make Ambari to look for an older port value.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
Diff: https://reviews.apache.org/r/46186/diff/
Testing
-------
Unit test has passed.
Manual Test in progress.
Thanks,
jun aoki
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128975
-----------------------------------------------------------
Ship it!
Ship It!
- bhuvnesh chaudhary
On April 14, 2016, 7:18 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 7:18 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128969
-----------------------------------------------------------
Ship it!
Ship It!
- Goutam Tadi
On April 14, 2016, 7:18 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 7:18 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/
-----------------------------------------------------------
(Updated April 14, 2016, 7:18 p.m.)
Review request for Ambari.
Changes
-------
Fixed according with feedback
Bugs: AMBARI-15852
https://issues.apache.org/jira/browse/AMBARI-15852
Repository: ambari
Description
-------
HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
This change is to make Ambari to look for an older port value.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py 3f6c371
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
Diff: https://reviews.apache.org/r/46186/diff/
Testing
-------
Unit test has passed.
Manual Test in progress.
Thanks,
jun aoki
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by jun aoki <ju...@gmail.com>.
> On April 14, 2016, 2:33 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py, line 92
> > <https://reviews.apache.org/r/46186/diff/1/?file=1343689#file1343689line92>
> >
> > Are the expected return values just 0 and 1?
> >
> > If yes, the function can have a name similar to __is_process_running
This returns a string of command wihich will be passed to not_if and only_if parameters.
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128823
-----------------------------------------------------------
On April 14, 2016, 2:19 a.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 2:19 a.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 46186: Changing HAWQ Ports through Ambari prevents
HAWQ service from restarting
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46186/#review128823
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 92)
<https://reviews.apache.org/r/46186/#comment192275>
Are the expected return values just 0 and 1?
If yes, the function can have a name similar to __is_process_running
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py (line 96)
<https://reviews.apache.org/r/46186/#comment192277>
You may use the component attribute map to get program_name or process_name.
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py (line 25)
<https://reviews.apache.org/r/46186/#comment192276>
You may move this attribute map to hawq_constants if you think that is the right place.
- Matt
On April 13, 2016, 7:19 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46186/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 7:19 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-15852
> https://issues.apache.org/jira/browse/AMBARI-15852
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HAWQ restart after port change will fail because Ambari looks for a currently running process with a new port number.
> This change is to make Ambari to look for an older port value.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/common.py 413cf1a
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py f2ec914
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqsegment.py 636dcad
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py 67d1cb0
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstatus.py 92ac0af
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/utils.py 0baa4c5
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqmaster.py c18941c
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqsegment.py 17d7473
> ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 44565b3
>
> Diff: https://reviews.apache.org/r/46186/diff/
>
>
> Testing
> -------
>
> Unit test has passed.
> Manual Test in progress.
>
>
> Thanks,
>
> jun aoki
>
>