You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/01/14 10:26:03 UTC
[GitHub] [phoenix] virajjasani opened a new pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
virajjasani opened a new pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#issuecomment-760108433
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 21s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| -1 :x: | markdownlint | 0m 2s | The patch generated 33 new + 0 unchanged - 0 fixed = 33 total (was 0) |
| -1 :x: | pylint | 0m 4s | The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | whitespace | 0m 0s | The patch 11 line(s) with tabs. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 6m 37s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1088 |
| Optional Tests | dupname asflicense pylint markdownlint |
| uname | Linux ee2e2998ca4b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 2817dee |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/1/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/1/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/1/artifact/yetus-general-check/output/whitespace-eol.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/1/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#discussion_r557478985
##########
File path: dev/misc_utils/git_jira_fix_version_check.py
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+############################################################################
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+############################################################################
+
+
+import inspect
+import os
+import re
+import subprocess
+
+from jira import JIRA
+
+first_exclude_commit_hash = input("First commit hash to start excluding commits from history: ")
+fix_version = input("Fix Version: ")
+
+jira = JIRA({"server": "https://issues.apache.org/jira"})
Review comment:
Makes sense, Tephra, Omid too can be released. Nice one, let me make Jira project name as well as absolute path of local project dir as parameters so that various branches and projects can be covered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty closed pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#issuecomment-760434146
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 48s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 5s | Maven dependency ordering for branch |
| +0 | hbaserecompile | 12m 4s | HBase recompiled. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch |
| +0 | hbaserecompile | 6m 55s | HBase recompiled. |
| -1 :x: | markdownlint | 0m 3s | The patch generated 35 new + 0 unchanged - 0 fixed = 35 total (was 0) |
| -1 :x: | pylint | 0m 3s | The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) |
| -1 :x: | whitespace | 0m 0s | The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 1s | ASF License check generated no output? |
| | | 20m 49s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/4/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1088 |
| Optional Tests | dupname asflicense pylint markdownlint |
| uname | Linux 09630633fa79 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 9d171c0 |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/4/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/4/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/4/artifact/yetus-general-check/output/whitespace-eol.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/4/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Max. process+thread count | 96 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/4/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#issuecomment-760120149
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 7s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | Maven dependency ordering for patch |
| -1 :x: | markdownlint | 0m 1s | The patch generated 32 new + 0 unchanged - 0 fixed = 32 total (was 0) |
| -1 :x: | pylint | 0m 3s | The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0) |
| -1 :x: | whitespace | 0m 0s | The patch 11 line(s) with tabs. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 6m 18s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1088 |
| Optional Tests | dupname asflicense pylint markdownlint |
| uname | Linux dbc608040d1b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 2817dee |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/2/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/2/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/2/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/2/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#discussion_r557415917
##########
File path: dev/misc_utils/git_jira_fix_version_check.py
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+############################################################################
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+############################################################################
+
+
+import inspect
+import os
+import re
+import subprocess
+
+from jira import JIRA
+
+first_exclude_commit_hash = input("First commit hash to start excluding commits from history: ")
+fix_version = input("Fix Version: ")
+
+jira = JIRA({"server": "https://issues.apache.org/jira"})
Review comment:
As we'll soon need to release -queryserver and -connectors a well, can you make
the repository directory and the JIRA project name into parameters ?
That way we can use this for other branches and projects without having to deuplicate it into each one.
##########
File path: dev/misc_utils/git_jira_fix_version_check.py
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+############################################################################
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+############################################################################
+
+
+import inspect
+import os
+import re
+import subprocess
+
+from jira import JIRA
+
+first_exclude_commit_hash = input("First commit hash to start excluding commits from history: ")
+fix_version = input("Fix Version: ")
+
+jira = JIRA({"server": "https://issues.apache.org/jira"})
+os.chdir(os.path.dirname(os.path.abspath(inspect.getfile(inspect.currentframe()))))
+os.chdir('..')
+os.chdir('..')
+git_status_msg = subprocess.check_output(['git', 'status']).decode("utf-8")
+print('\nCheck git status output and verify expected branch')
+print(git_status_msg)
+
+print('\nJira/Git commit message diff starting: ##############################################')
+for commit in subprocess.check_output(['git', 'log', '--pretty=oneline']).decode("utf-8").splitlines():
+ if commit.startswith(first_exclude_commit_hash):
+ print("Found first commit hash after which git history is redundant. commit: " + first_exclude_commit_hash)
+ print("Exiting successfully")
+ break
+ if re.search('revert', commit, re.IGNORECASE):
+ print("Commit seems reverted. \t\t\t Commit: " + commit)
+ continue
+ if 'PHOENIX-' not in commit:
+ print("WARN: Jira not found. \t\t\t Commit: " + commit)
+ continue
+ jira_num = ''
+ for c in commit.split('PHOENIX-')[1]:
+ if c.isdigit():
+ jira_num = jira_num + c
+ else:
+ break
+ issue = jira.issue('PHOENIX-' + jira_num)
+ expected_fix_version = False
+ for version in issue.fields.fixVersions:
+ if version.name == fix_version:
+ expected_fix_version = True
+ break
+ if not expected_fix_version:
+ print("Jira not present with version: " + fix_version + ". \t Commit: " + commit)
+ continue
+ if issue.fields.resolution is None or issue.fields.resolution.name != 'Fixed':
+ print("Jira is not resolved yet? \t\t Commit: " + commit)
+ else:
+ # This means Jira corresponding to current commit message is resolved with expected fixVersion
+ # Noop by default, if needed, convert to print statement.
+ pass
+print('Jira/Git commit message diff completed: ##############################################')
+
+
+#
Review comment:
This doesn't seem to be very useful, the RM will always have the repo available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#discussion_r557549720
##########
File path: dev/misc_utils/git_jira_fix_version_check.py
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+############################################################################
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+############################################################################
+
+
+import inspect
+import os
+import re
+import subprocess
+
+from jira import JIRA
+
+first_exclude_commit_hash = input("First commit hash to start excluding commits from history: ")
+fix_version = input("Fix Version: ")
+
+jira = JIRA({"server": "https://issues.apache.org/jira"})
Review comment:
Btw I believe this line might remain same because Jira server address remains same regardless of projects. However, `project name` and `repository directory` are parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#issuecomment-760329708
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 31s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 5m 12s | Maven dependency ordering for branch |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| -1 :x: | markdownlint | 0m 1s | The patch generated 34 new + 0 unchanged - 0 fixed = 34 total (was 0) |
| -1 :x: | pylint | 0m 3s | The patch generated 12 new + 0 unchanged - 0 fixed = 12 total (was 0) |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. |
||| _ Other Tests _ |
| +0 :ok: | asflicense | 0m 0s | ASF License check generated no output? |
| | | 6m 22s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1088 |
| Optional Tests | dupname asflicense pylint markdownlint |
| uname | Linux 73da3cf76a7d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 2817dee |
| markdownlint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/3/artifact/yetus-general-check/output/diff-patch-markdownlint.txt |
| pylint | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/3/artifact/yetus-general-check/output/diff-patch-pylint.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/3/artifact/yetus-general-check/output/whitespace-eol.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/3/artifact/yetus-general-check/output/whitespace-tabs.txt |
| Max. process+thread count | 52 (vs. ulimit of 30000) |
| modules | C: U: |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1088/3/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 pylint=2.4.4 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] virajjasani commented on a change in pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#discussion_r557625431
##########
File path: dev/misc_utils/git_jira_fix_version_check.py
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+############################################################################
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+############################################################################
+
+
+import inspect
+import os
+import re
+import subprocess
+
+from jira import JIRA
+
+first_exclude_commit_hash = input("First commit hash to start excluding commits from history: ")
+fix_version = input("Fix Version: ")
+
+jira = JIRA({"server": "https://issues.apache.org/jira"})
Review comment:
Great thought! Let me keep it in parameter with default as ASF Jira url 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] stoty commented on a change in pull request #1088: PHOENIX-6314 : Utility to identify git commit / Jira fixVersion discrepancies for RC preparation
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #1088:
URL: https://github.com/apache/phoenix/pull/1088#discussion_r557574008
##########
File path: dev/misc_utils/git_jira_fix_version_check.py
##########
@@ -0,0 +1,107 @@
+#!/usr/bin/env python
+############################################################################
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+############################################################################
+
+
+import inspect
+import os
+import re
+import subprocess
+
+from jira import JIRA
+
+first_exclude_commit_hash = input("First commit hash to start excluding commits from history: ")
+fix_version = input("Fix Version: ")
+
+jira = JIRA({"server": "https://issues.apache.org/jira"})
Review comment:
If someone outside ASF wants to use it, he can always overwrite the JIRA URL :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org