[jira] [Reopened] (OFBIZ-5257) Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong

["Pierre Smits (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pierre Smits reopened OFBIZ-5257:
---------------------------------


Best practice of naming methods that check statuses is in favour of starting with 'check'
                
> Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong
> -----------------------------------------------------------------------
>
>                 Key: OFBIZ-5257
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5257
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>    Affects Versions: SVN trunk
>            Reporter: Pierre Smits
>             Fix For: SVN trunk
>
>
> The name of this method in accounting services doesn't tell what it does. 
> You have to go into the description what the functionality of the method is, namely checking whether an invoice is a foreign currency.
> Best practice is to have the name of the function reflect the functionality.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira