You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/07 12:35:08 UTC
[GitHub] [flink] dufeng1010 opened a new pull request #13976: [FLINK-20037][Table SQL / API]update comment problem in fromValues(AbstractDataType rowType, Obj…
dufeng1010 opened a new pull request #13976:
URL: https://github.com/apache/flink/pull/13976
I find a comment problem in fromValues(AbstractDataType<?> rowType, Object... values) method of TableEnvironment, i think second column name is "name" not "f1". this is my first issue, if there is a problem, please understand
<p>Examples:
* <pre>{@code
* tEnv.fromValues(
* DataTypes.ROW(
* DataTypes.FIELD("id", DataTypes.DECIMAL(10, 2)),
* DataTypes.FIELD("name", DataTypes.STRING())
* ),
* row(1, "ABC"),
* row(2L, "ABCDE")
* )
* }</pre>
* will produce a Table with a schema as follows:
* <pre>{@code
* root
* |-- id: DECIMAL(10, 2)
* |-- f1: STRING
* }</pre>
*
* <p>For more examples see {@link #fromValues(Object...)}.
*
* @param rowType Expected row type for the values.
* @param values Expressions for constructing rows of the VALUES table.
* @see #fromValues(Object...)
*/
default Table fromValues(AbstractDataType<?> rowType, Object... values) {
// It is necessary here to implement TableEnvironment#fromValues(Object...) for BatchTableEnvImpl.
// In scala varargs are translated to Seq. Due to the type erasure Seq<Expression> and Seq<Object>
// are the same. It is not a problem in java as varargs in java are translated to an array.
return fromValues(rowType, Arrays.asList(values));
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13976: [FLINK-20037][Table SQL / API]update comment problem in fromValues(AbstractDataType rowType, Obj…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13976:
URL: https://github.com/apache/flink/pull/13976#issuecomment-723441058
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit cefb2787aa9461b6803721e99b551e7ca4f6ba66 (Sat Nov 07 12:37:24 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20037).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #13976: [FLINK-20037][Table SQL / API]update comment problem in fromValues(AbstractDataType rowType, Obj…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #13976:
URL: https://github.com/apache/flink/pull/13976
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13976: [FLINK-20037][Table SQL / API]update comment problem in fromValues(AbstractDataType rowType, Obj…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13976:
URL: https://github.com/apache/flink/pull/13976#issuecomment-723443659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cefb2787aa9461b6803721e99b551e7ca4f6ba66",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9258",
"triggerID" : "cefb2787aa9461b6803721e99b551e7ca4f6ba66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cefb2787aa9461b6803721e99b551e7ca4f6ba66 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13976: [FLINK-20037][Table SQL / API]update comment problem in fromValues(AbstractDataType rowType, Obj…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13976:
URL: https://github.com/apache/flink/pull/13976#issuecomment-723443659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cefb2787aa9461b6803721e99b551e7ca4f6ba66",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cefb2787aa9461b6803721e99b551e7ca4f6ba66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cefb2787aa9461b6803721e99b551e7ca4f6ba66 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13976: [FLINK-20037][Table SQL / API]update comment problem in fromValues(AbstractDataType rowType, Obj…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13976:
URL: https://github.com/apache/flink/pull/13976#issuecomment-723443659
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "cefb2787aa9461b6803721e99b551e7ca4f6ba66",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9258",
"triggerID" : "cefb2787aa9461b6803721e99b551e7ca4f6ba66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cefb2787aa9461b6803721e99b551e7ca4f6ba66 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9258)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org