[GitHub] twalthr commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #6455: [FLINK-9997] [table] Improve Expression Reduce
URL: https://github.com/apache/flink/pull/6455#discussion_r221923802
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
 ##########
 @@ -480,11 +480,20 @@ abstract class BatchTableEnvironment(
       normalizedPlan
     }
 
-    // 4. optimize the physical Flink plan
+    // 4. optimize the logical Flink plan
+    val flinkLogicalOptRuleSet = getFlinkLogicalOptRuleSet
 
 Review comment:
   I'm not sure about adding another step in the optimization phase. You mentioned that "If adding ReduceExpressionRule.CALC to logical opt phase, it will increase the the search time.", do you have numbers for this? Otherwise I would add it to logical optimization phase because this is actually where it belongs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services