You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by HansBrende <gi...@git.apache.org> on 2018/05/18 22:57:19 UTC
[GitHub] any23 pull request #85: ANY23-348 handle malformed microdata types gracefull...
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/85
ANY23-348 handle malformed microdata types gracefully
I did two things:
(1) Treat blank microdata types as if they were null
(2) For other varieties of malformed microdata types, first attempt to fix them by trimming leading & trailing whitespaces and url-encoding illegal characters. If that fails, then only throw a fatal error if the microdata parser error mode is set to STOP_AT_FIRST_ERROR; otherwise, add the error to the error list, treat the type as if it were null, and continue parsing.
mvn clean test -> all tests pass
@lewismc what do you think?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-348
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 61d91b55053bb8e3b087216b082594fa1db85a85
Author: Hans <fi...@...>
Date: 2018-05-18T22:38:28Z
ANY23-348 handle malformed microdata types gracefully
----
---
[GitHub] any23 issue #85: ANY23-348 handle malformed microdata types gracefully
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/85
I think this all sounds reasonable. +1
---
[GitHub] any23 pull request #85: ANY23-348 handle malformed microdata types gracefull...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/any23/pull/85
---