You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/04 13:55:06 UTC
[GitHub] [skywalking-cli] fgksgf opened a new pull request #51: Fix a bug and make several improvements
fgksgf opened a new pull request #51:
URL: https://github.com/apache/skywalking-cli/pull/51
## Bug
+ Due to the use of the wrong delimiter `,` (should be `, `) to split the string as parameters, resulting in the empty data of response latency.
## Improvements
+ Set default values for color and height of buttons.
+ Get titles of buttons from json's keys, instead of hard code.
+ Add check for the existence of items (`metrics`, `responseLatency` and `heatMap`) in the template file.
+ Add meaningful labels for global response latency line charts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #51: Fix a bug and make several improvements
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #51:
URL: https://github.com/apache/skywalking-cli/pull/51#issuecomment-668612871
Good to have these percentile labels back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #51: Fix a bug and make several improvements
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #51:
URL: https://github.com/apache/skywalking-cli/pull/51
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on pull request #51: Fix a bug and make several improvements
Posted by GitBox <gi...@apache.org>.
fgksgf commented on pull request #51:
URL: https://github.com/apache/skywalking-cli/pull/51#issuecomment-668615159
> Good to have these percentile labels back.
Just followed the advice from the mentor @kezhenxu94 : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #51: Fix a bug and make several improvements
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #51:
URL: https://github.com/apache/skywalking-cli/pull/51#issuecomment-668616120
I think you have been more and more familiar with this subproject. Good to see the progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org