[GitHub] [dubbo-go-pixiu] mark4z commented on a diff in pull request #540: Control Panel: Feat/service metadata

["mark4z (via GitHub)" <gi...@apache.org>]

mark4z commented on code in PR #540:
URL: https://github.com/apache/dubbo-go-pixiu/pull/540#discussion_r1216117589


##########
manifests/charts/base/files/gen-istio-cluster.yaml:
##########
@@ -6842,14 +6960,14 @@ subjects:
 ---
 # Source: base/templates/default.yaml
 apiVersion: admissionregistration.k8s.io/v1
-kind: ValidatingWebhookConfiguration
+kind: Val:wqidatingWebhookConfiguration

Review Comment:
   这里是不是不小心改的？理论上这里的文件是自动生成的



##########
bin/update_crds.sh:
##########
@@ -29,14 +29,14 @@ SCRIPTPATH="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 ROOTDIR=$(dirname "${SCRIPTPATH}")
 cd "${ROOTDIR}"
 
-REPO="github.com/istio/api"
+REPO="github.com/MasterKenway/operator-api"
 # using the pseudo version we have in go.mod file. e.g. v.0.0.0-<timestamp>-<SHA>
 # first check if there's a replace: e.g. replace istio.io/api => github.com/USER/istioapi v0.0.0-<timestamp>-<SHA>
-SHA=$(grep "istio.io/api" go.mod | grep "^replace" | awk -F "-" '{print $NF}')
+SHA=$(grep "MasterKenway/operator-api" go.mod | grep "^replace" | awk -F "-" '{print $NF}')

Review Comment:
   现在可以改回去了



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org