You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/19 23:23:20 UTC
[GitHub] [incubator-pinot] mayankshriv opened a new pull request #4453:
Issue #4450: Support parsing of `Order By` clause in PQL compiler.
mayankshriv opened a new pull request #4453: Issue #4450: Support parsing of `Order By` clause in PQL compiler.
URL: https://github.com/apache/incubator-pinot/pull/4453
This is the first of several PR's to come for implementing group-by +
order-by support in PQL. The changes in this PR are limited to parsing
the order-by clause.
1. Added a top level orderBy field in BrokerRequest. The existing
selectionSort field is tied to selection only queries, and removing it
will break backward compatibility. Once the code is moved to use
PinotQuery instead of BrokerRequest, this will get cleaned up
automatically.
2. Moved to latest Thrift version 0.12.0. This required removing the
org.apache.commons.lang3 exclusion from pom.xml.
3. Added unit test for order-by compilation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org