You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/30 14:15:48 UTC
Review Request 34842: Ambari does not give a warning if
tez.am.resource.memory.mb is greater than yarn max container size
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34842/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-11556
https://issues.apache.org/jira/browse/AMBARI-11556
Repository: ambari
Description
-------
Likewise for tez.task.resource.memory.mb
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py ec84818
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f4727a0
Diff: https://reviews.apache.org/r/34842/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 34842: Ambari does not give a warning if
tez.am.resource.memory.mb is greater than yarn max container size
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34842/#review85881
-----------------------------------------------------------
When tested end-to-end, below error is hit. We need to take into account that certain configs wont be available when the service is not selected etc.
Please look at similar fix made in AMBARI-11538.
{noformat}
Traceback (most recent call last):
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 154, in <module>
main(sys.argv)
File "/var/lib/ambari-server/resources/scripts/stack_advisor.py", line 113, in main
result = stackAdvisor.validateConfigurations(services, hosts)
File "/var/lib/ambari-server/resources/scripts/../stacks/stack_advisor.py", line 464, in validateConfigurations
validationItems = self.getConfigurationsValidationItems(services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.0.6/services/stack_advisor.py", line 341, in getConfigurationsValidationItems
resultItems = method(siteProperties, siteRecommendations, configurations, services, hosts)
File "/var/lib/ambari-server/resources/scripts/./../stacks/HDP/2.2/services/stack_advisor.py", line 588, in validateTezConfigurations
yarnMaxAllocationSize = min(30 * int(configurations["yarn-site"]["properties"]["yarn.scheduler.minimum-allocation-mb"]),int(configurations["yarn-site"]["properties"]["yarn.scheduler.maximum-allocation-mb"]))
KeyError: 'yarn-site'
{noformat}
- Srimanth Gunturi
On May 30, 2015, 1:23 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34842/
> -----------------------------------------------------------
>
> (Updated May 30, 2015, 1:23 p.m.)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-11556
> https://issues.apache.org/jira/browse/AMBARI-11556
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Likewise for tez.task.resource.memory.mb
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py ec84818
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f4727a0
>
> Diff: https://reviews.apache.org/r/34842/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 34842: Ambari does not give a warning if
tez.am.resource.memory.mb is greater than yarn max container size
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34842/#review85865
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 30, 2015, 4:23 після полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34842/
> -----------------------------------------------------------
>
> (Updated Травень 30, 2015, 4:23 після полудня)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-11556
> https://issues.apache.org/jira/browse/AMBARI-11556
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Likewise for tez.task.resource.memory.mb
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py ec84818
> ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f4727a0
>
> Diff: https://reviews.apache.org/r/34842/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 34842: Ambari does not give a warning if
tez.am.resource.memory.mb is greater than yarn max container size
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34842/
-----------------------------------------------------------
(Updated May 30, 2015, 1:23 p.m.)
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-11556
https://issues.apache.org/jira/browse/AMBARI-11556
Repository: ambari
Description
-------
Likewise for tez.task.resource.memory.mb
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py ec84818
ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py f4727a0
Diff: https://reviews.apache.org/r/34842/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk