You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dave Brosius <db...@mebigfatguy.com> on 2013/05/20 21:46:51 UTC
Review Request: Nop assignment due to missing 'this.'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11245/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
simple missed 'this.' causes self assignment, and not setting to field, patch adds
Diffs
-----
engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceVO.java 04714a6
Diff: https://reviews.apache.org/r/11245/diff/
Testing
-------
Thanks,
Dave Brosius
Re: Review Request: Nop assignment due to missing 'this.'
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11245/#review20823
-----------------------------------------------------------
Ship it!
45d2e60656a7c9b2b4171bc63450afa229ca4e75
Consider using git format-patch so your contribution can be acknowledged.
- Prasanna Santhanam
On May 20, 2013, 7:47 p.m., Dave Brosius wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11245/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 7:47 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> simple missed 'this.' causes self assignment, and not setting to field, patch adds
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceVO.java 04714a6
>
> Diff: https://reviews.apache.org/r/11245/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dave Brosius
>
>
Re: Review Request: Nop assignment due to missing 'this.'
Posted by Dave Brosius <db...@mebigfatguy.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11245/
-----------------------------------------------------------
(Updated May 20, 2013, 7:47 p.m.)
Review request for cloudstack.
Description
-------
simple missed 'this.' causes self assignment, and not setting to field, patch adds
Diffs
-----
engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceVO.java 04714a6
Diff: https://reviews.apache.org/r/11245/diff/
Testing
-------
Thanks,
Dave Brosius