[GitHub] [incubator-hudi] yanghua commented on a change in pull request #991: Hudi Test Suite (Refactor)

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #991: Hudi Test Suite (Refactor) 
URL: https://github.com/apache/incubator-hudi/pull/991#discussion_r341896396
 
 

 ##########
 File path: hudi-bench/src/main/java/org/apache/hudi/bench/dag/nodes/DagNode.java
 ##########
 @@ -0,0 +1,104 @@
+package org.apache.hudi.bench.dag.nodes;
+
+import java.util.ArrayList;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Objects;
+import java.util.UUID;
+import org.apache.hudi.bench.configuration.DeltaConfig.Config;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+
+/**
+ * Represents a Node in the DAG of operations for a workflow.
+ */
+public abstract class DagNode<O> implements Comparable<DagNode<O>> {
 
 Review comment:
   Since every subclass of `DagNode` has defined a `execute` and we did not use its return value in `DagScheduler`. 
   Shall we define an abstract method which signature is:
   
   ```
     public abstract void execute(ExecutionContext context) throws Exception;
   ```
   
   To provide different runtime context information, we can define a context POJO, e.g. `ExecutionContext`.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services