[GitHub] [pulsar] codelipenghui commented on a change in pull request #4400: [WIP-Rebase] PIP 37: [pulsar-client] support large message size

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #4400:
URL: https://github.com/apache/pulsar/pull/4400#discussion_r432252079



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
##########
@@ -96,6 +96,9 @@ private ProducerBuilderImpl(PulsarClientImpl client, ProducerConfigurationData c
 
     @Override
     public CompletableFuture<Producer<T>> createAsync() {
+        // config validation
+        checkArgument(!(conf.isBatchingEnabled() && conf.isChunkingEnabled()),

Review comment:
       @rdhabalia The change looks good to me. About to enable the chunk, is it possible to add a config for the max chunk size and enable batching at the same time. If the message size is greater than the max chunk size and the chunk is enabled, we send messages with chunks, If the message is size is smaller than the max chunk size, we also can add them to a batch and if chunk is enabled, we make sure the match size can not exceed the max chunk size. So that it can be better applied when the user cannot confirm the message size for example from 100 bytes to 10MB. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org