You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/08/05 22:33:15 UTC
[jira] Created: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
electionAlg should default to FLE (3) - regression
--------------------------------------------------
Key: ZOOKEEPER-499
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
Project: Zookeeper
Issue Type: Bug
Components: server, tests
Affects Versions: 3.2.0
Reporter: Patrick Hunt
Priority: Blocker
Fix For: 3.2.1, 3.3.0
there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741802#action_12741802 ]
Hudson commented on ZOOKEEPER-499:
----------------------------------
Integrated in ZooKeeper-trunk #412 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/412/])
. electionAlg should default to FLE (3) - regression (phunt via mahadev)
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-499:
-----------------------------------
Attachment: ZOOKEEPER-499_br3.2.patch
ZOOKEEPER-499.patch
updated patch based on ben's comments:
1) using the name of the package is fine, this is actually taking advantage of a feature of log4j
http://logging.apache.org/log4j/1.2/manual.html
"Each enabled logging request for a given logger will be forwarded to all the appenders in that logger as well as the appenders higher in the hierarchy."
2) I was removing the appender from the wrong logger, I've updated the patch to correctly remove.
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-499:
-----------------------------------
Attachment: ZOOKEEPER-499_br3.2.patch
ZOOKEEPER-499.patch
patches to fix on trunk and branch (br3.2 is the branch patch)
this fixes the problem - electionAlg again defaults to 3
it also adds a test to verify fle is used by default
it also fixes a test that fails if fle is used (vs algo 0) which is due to a difference in the way jdk exposes
unresolved host names when using udp vs tcp.
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-499:
--------------------------------------
Assignee: Patrick Hunt
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-499:
-----------------------------------
Release Note:
workaround in 3.2.0 (this only effects 3.2.0)
set electionAlg=3 in server config files.
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-499:
-----------------------------------
Status: Patch Available (was: Open)
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-499:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. thanks pat.
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740374#action_12740374 ]
Hadoop QA commented on ZOOKEEPER-499:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12415671/ZOOKEEPER-499_br3.2.patch
against trunk revision 801839.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/171/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/171/console
This message is automatically generated.
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-499:
------------------------------------
Status: Open (was: Patch Available)
this looks good pat, but when you first get the logger, why are you using the package name? if you are going to use the package name shouldn't you get the package from the class file?
in the second test, you get the logger using a package to add an appender, but remove using the class. couldn't that cause a problem potentially?
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-499:
-----------------------------------
Status: Patch Available (was: Open)
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-499) electionAlg should default to FLE
(3) - regression
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741592#action_12741592 ]
Mahadev konar commented on ZOOKEEPER-499:
-----------------------------------------
+1 this looks good. ..
> electionAlg should default to FLE (3) - regression
> --------------------------------------------------
>
> Key: ZOOKEEPER-499
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-499
> Project: Zookeeper
> Issue Type: Bug
> Components: server, tests
> Affects Versions: 3.2.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Blocker
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-499.patch, ZOOKEEPER-499.patch, ZOOKEEPER-499_br3.2.patch, ZOOKEEPER-499_br3.2.patch
>
>
> there's a regression in 3.2 - electionAlg is no longer defaulting to 3 (incorrectly defaults to 0)
> also - need to have tests to validate this
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.