You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by hvanhovell <gi...@git.apache.org> on 2016/07/11 08:57:56 UTC

[GitHub] spark pull request #14132: [SPARK-16475][SQL][WIP] Broadcast Hint for SQL Qu...

Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14132#discussion_r70222526
  
    --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
    @@ -945,8 +955,12 @@ SIMPLE_COMMENT
         : '--' ~[\r\n]* '\r'? '\n'? -> channel(HIDDEN)
         ;
     
    +BRACKETED_EMPTY_COMMENT
    --- End diff --
    
    Do we need this because the BRACKETED_COMMENT rule is now expecting at least one character?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org