[jira] Commented: (SHINDIG-426) Wrong function name in call to messages service; and MessagesService class missing

["Chris Chabot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613777#action_12613777 ] 

Chris Chabot commented on SHINDIG-426:
--------------------------------------

Hey Erel, these patches are looking good.

I would like to keep calling it 'sendMessage' though and not 'create' since i i think that covers the essence of what it does better (you send a letter, not 'create' it :P)

I'll apply the patch as soon as i have a moment to whip up a similar class for the socialrest interface, i'm a bit weary for them to become unbalanced since i hope we'll switch over to it completely somewhere in the ('near') future.

nice work!

> Wrong function name in call to messages service; and MessagesService class missing
> ----------------------------------------------------------------------------------
>
>                 Key: SHINDIG-426
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-426
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (PHP)
>            Reporter: Erel Segal
>         Attachments: MessagesService.patch
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> In OpenSocialDataHandler, there is a call to:
> 		$this->messagesHandler->sendMessage($peopleIds, $message, $request->getToken());
> But in BasicMessagesService , there is no such function - the function is called createMessage.
> Additionally, I think there should be a file shindig/php/src/socialdata/opensocial/MessagesService.php that contains an abstract class MessagesService , and  the class BasicMessagesService should inherit from it. Just like the other 3 services (ActivitiesService, DataService, PeopleService).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.