[GitHub] [rocketmq-connect] yhx-coder commented on a diff in pull request #200: [ISSUE#173]Connect Exporter for Prometheus

[GitBox <gi...@apache.org>]

yhx-coder commented on code in PR #200:
URL: https://github.com/apache/rocketmq-connect/pull/200#discussion_r926321950


##########
connectors/rocketmq-connect-metrics-exporter/src/main/java/org/apache/rocket/connect/metrics/export/sink/connector/MetricsExportSinkTask.java:
##########
@@ -0,0 +1,37 @@
+package org.apache.rocket.connect.metrics.export.sink.connector;
+
+import io.openmessaging.KeyValue;
+import io.openmessaging.connector.api.component.task.sink.SinkTask;
+import io.openmessaging.connector.api.component.task.sink.SinkTaskContext;
+import io.openmessaging.connector.api.data.ConnectRecord;
+import io.openmessaging.connector.api.errors.ConnectException;
+import java.util.List;
+import org.apache.rocket.connect.metrics.export.sink.util.ServiceProvicerUtil;
+
+
+public class MetricsExportSinkTask extends SinkTask {
+    private List<MetricsExporter> metricsExporters;

Review Comment:
   Sorry not yet :( . But I am trying my best to finish a exporter for Prometheus which gets the metrics from the log files, and some preliminary knowledge is got. And I hear  the sftp source connector (my upstream task) is designing in the last weekly meeting. So I'm waiting for the implementation `ConnectRecord` in it in order to complete my parsing.   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org