[GitHub] [doris] yangzhg commented on a diff in pull request #15849: [feature-wip](MTMV) Support table aliases when creating a materialized view with multiple tables

[GitBox <gi...@apache.org>]

yangzhg commented on code in PR #15849:
URL: https://github.com/apache/doris/pull/15849#discussion_r1068869019


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CreateMultiTableMaterializedViewStmt.java:
##########
@@ -43,7 +46,7 @@ public class CreateMultiTableMaterializedViewStmt extends CreateTableStmt {
     private final MVRefreshInfo refreshInfo;
     private final QueryStmt queryStmt;
     private Database database;
-    private final Map<String, OlapTable> olapTables = Maps.newHashMap();
+    private List<TableRef> tableRefs;

Review Comment:
   why use list， map maybe better， use alias or tablename as key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org