[GitHub] [beam] regadas commented on issue #10869: [BEAM-9321] Add BigQuery Avro logical type support on write

[GitBox <gi...@apache.org>]

regadas commented on issue #10869: [BEAM-9321] Add BigQuery Avro logical type support on write
URL: https://github.com/apache/beam/pull/10869#issuecomment-593551872
 
 
   Hi, I think we need to consider a few things:
   
   1) in BigQuery this is not the default behavior; Users need to explicitly enable `useAvroLogicalTypes` to have their types converted to the data types mentioned in the doc as opposed to the underlying avro raw type. This means that tables will have different schemas!
   
   2) The previous Beam version was already released with this; Logical Types are not respected and created Table will have schemas where types match the avro raw types. 
   
   It makes sense that logical types should be respected by default (it option to disable), but because of the previous points I don't think we can. or even if it's a good idea.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services