You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2016/12/28 00:30:00 UTC

[5/5] maven-wagon git commit: [WAGON-481] Sensitive (auth) information is not cleared when HttpClientWagon is disconnected

[WAGON-481] Sensitive (auth) information is not cleared when HttpClientWagon is disconnected


Project: http://git-wip-us.apache.org/repos/asf/maven-wagon/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/faee1f35
Tree: http://git-wip-us.apache.org/repos/asf/maven-wagon/tree/faee1f35
Diff: http://git-wip-us.apache.org/repos/asf/maven-wagon/diff/faee1f35

Branch: refs/heads/jetty-8
Commit: faee1f3561fd1793e292a5ec0995ceaaeac06198
Parents: f9f582e
Author: Michael Osipov <mi...@apache.org>
Authored: Wed Dec 28 01:28:49 2016 +0100
Committer: Michael Osipov <mi...@apache.org>
Committed: Wed Dec 28 01:28:49 2016 +0100

----------------------------------------------------------------------
 .../wagon/providers/http/AbstractHttpClientWagon.java   | 12 ++++++++++++
 1 file changed, 12 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/faee1f35/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
----------------------------------------------------------------------
diff --git a/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
index 9ef9544..c693cd0 100755
--- a/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
+++ b/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
@@ -469,6 +469,18 @@ public abstract class AbstractHttpClientWagon
         {
             httpClientConnectionManager.closeIdleConnections( 0, TimeUnit.MILLISECONDS );
         }
+
+        if ( authCache != null )
+        {
+            authCache.clear();
+            authCache = null;
+        }
+
+        if ( credentialsProvider != null )
+        {
+            credentialsProvider.clear();
+            credentialsProvider = null;
+        }
     }
 
     public static void setPersistentPool( boolean persistentPool )