You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/12/12 17:49:53 UTC
Review Request 41315: Upgrade mesos dependency to 0.24.1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/
-----------------------------------------------------------
Review request for Aurora, Maxim Khutornenko and Vinod Kone.
Repository: aurora
Description
-------
Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
[1] http://mesos.apache.org/documentation/latest/upgrades/
Diffs
-----
3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
build.gradle aeefc572c4dd854bb263000c740af8570085123d
docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
Diff: https://reviews.apache.org/r/41315/diff/
Testing
-------
Successfully ran end-to-end tests.
Thanks,
Bill Farner
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 14, 2015, 10:38 a.m., Zameer Manji wrote:
> > Mind linking this to https://issues.apache.org/jira/browse/AURORA-1543 and assigning the ticket to yourself?
Thanks for the reminder, done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110281
-----------------------------------------------------------
On Dec. 12, 2015, 8:49 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 8:49 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110281
-----------------------------------------------------------
Ship it!
Mind linking this to https://issues.apache.org/jira/browse/AURORA-1543 and assigning the ticket to yourself?
- Zameer Manji
On Dec. 12, 2015, 8:49 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 8:49 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110093
-----------------------------------------------------------
Ship it!
Master (3277976) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 12, 2015, 4:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 4:49 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Bill Farner <wf...@apache.org>.
> On Dec. 14, 2015, 4:47 a.m., Stephan Erb wrote:
> > I'd vote for sticking with 0.24.1, as Mesos devs have just recently urged users not to skip updates (http://www.mail-archive.com/user@mesos.apache.org/msg05379.html).
>
> Maxim Khutornenko wrote:
> +1. I don't think we can skip 0.24 due to protobuf -> JSON format change in master ZK registration: http://mesos.apache.org/documentation/latest/upgrades/. My understanding is that 0.25 does not have dual write for ZK making seemless upgrade impossible.
Thanks for the input.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110215
-----------------------------------------------------------
On Dec. 12, 2015, 8:49 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 8:49 a.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Dec. 14, 2015, 12:47 p.m., Stephan Erb wrote:
> > I'd vote for sticking with 0.24.1, as Mesos devs have just recently urged users not to skip updates (http://www.mail-archive.com/user@mesos.apache.org/msg05379.html).
+1. I don't think we can skip 0.24 due to protobuf -> JSON format change in master ZK registration: http://mesos.apache.org/documentation/latest/upgrades/. My understanding is that 0.25 does not have dual write for ZK making seemless upgrade impossible.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110215
-----------------------------------------------------------
On Dec. 12, 2015, 4:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 4:49 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110215
-----------------------------------------------------------
Ship it!
I'd vote for sticking with 0.24.1, as Mesos devs have just recently urged users not to skip updates (http://www.mail-archive.com/user@mesos.apache.org/msg05379.html).
- Stephan Erb
On Dec. 12, 2015, 5:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 5:49 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110314
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 14, 2015, 9:25 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2015, 9:25 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Zameer Manji.
>
>
> Bugs: AURORA-1543
> https://issues.apache.org/jira/browse/AURORA-1543
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 2:02 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1543
https://issues.apache.org/jira/browse/AURORA-1543
Repository: aurora
Description (updated)
-------
See summary.
Diffs
-----
3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
build.gradle aeefc572c4dd854bb263000c740af8570085123d
docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
Diff: https://reviews.apache.org/r/41315/diff/
Testing
-------
Successfully ran end-to-end tests.
Thanks,
Bill Farner
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/
-----------------------------------------------------------
(Updated Dec. 14, 2015, 1:25 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1543
https://issues.apache.org/jira/browse/AURORA-1543
Repository: aurora
Description
-------
Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
[1] http://mesos.apache.org/documentation/latest/upgrades/
Diffs
-----
3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
build.gradle aeefc572c4dd854bb263000c740af8570085123d
docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
Diff: https://reviews.apache.org/r/41315/diff/
Testing
-------
Successfully ran end-to-end tests.
Thanks,
Bill Farner
Re: Review Request 41315: Upgrade mesos dependency to 0.24.1.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41315/#review110259
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Dec. 12, 2015, 4:49 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41315/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2015, 4:49 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko and Vinod Kone.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Outstanding question - can we go straight to 0.25.0? Based on the upgrade docs [1], it doesn't appear that would be problematic. If we can do it, i think we should do so and i am happy to update this patch.
>
> [1] http://mesos.apache.org/documentation/latest/upgrades/
>
>
> Diffs
> -----
>
> 3rdparty/python/BUILD 1a80d66d0ab3a920cf1ddd774c922dbd71c574ad
> NEWS 6e158d0495afe8581540a1d9eba3082ada627fd3
> build-support/python/make-mesos-native-egg 47438c5b71d686c4a42ae3f46f3a7093b34f3909
> build.gradle aeefc572c4dd854bb263000c740af8570085123d
> docs/deploying-aurora-scheduler.md 812beafdc3b4c47fdc813d2dd2299b63407f8011
> examples/vagrant/provision-dev-cluster.sh 3e4bf325601fc2326743b1344d64980e8c881a11
>
> Diff: https://reviews.apache.org/r/41315/diff/
>
>
> Testing
> -------
>
> Successfully ran end-to-end tests.
>
>
> Thanks,
>
> Bill Farner
>
>