[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5612: Miscellaneous ArrayData Cleanup

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #5612:
URL: https://github.com/apache/arrow-datafusion/pull/5612#discussion_r1137394863


##########
datafusion/physical-expr/src/aggregate/sum.rs:
##########
@@ -236,15 +236,15 @@ impl Accumulator for SumAccumulator {
 
     fn update_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
         let values = &values[0];
-        self.count += (values.len() - values.data().null_count()) as u64;
+        self.count += (values.len() - values.null_count()) as u64;

Review Comment:
   This results in a test failure, as it reports the arguably correct null count, instead of 0 for NullArray. I'm not sure if this is a bug or not...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org