You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ct...@apache.org on 2025/06/28 00:51:45 UTC
(accumulo) 02/02: Trivial remove unused fields/methods
This is an automated email from the ASF dual-hosted git repository.
ctubbsii pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git
commit 0563f0f3b99ce6a7c97f967b30aac26b05720a75
Author: Christopher Tubbs <ct...@apache.org>
AuthorDate: Fri Jun 27 20:50:51 2025 -0400
Trivial remove unused fields/methods
---
.../accumulo/core/conf/HadoopCredentialProviderTest.java | 3 ---
.../accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java | 1 -
.../org/apache/accumulo/tserver/util/CreateEmptyTest.java | 7 -------
.../java/org/apache/accumulo/shell/ShellConfigTest.java | 3 ---
.../java/org/apache/accumulo/test/AuditMessageIT.java | 1 -
.../test/ComprehensiveTableOperationsIT_SimpleSuite.java | 15 ---------------
.../java/org/apache/accumulo/test/ImportExportIT.java | 1 -
7 files changed, 31 deletions(-)
diff --git a/core/src/test/java/org/apache/accumulo/core/conf/HadoopCredentialProviderTest.java b/core/src/test/java/org/apache/accumulo/core/conf/HadoopCredentialProviderTest.java
index 787052ef88..85b3f3738a 100644
--- a/core/src/test/java/org/apache/accumulo/core/conf/HadoopCredentialProviderTest.java
+++ b/core/src/test/java/org/apache/accumulo/core/conf/HadoopCredentialProviderTest.java
@@ -40,8 +40,6 @@ import org.apache.hadoop.hdfs.MiniDFSCluster;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -52,7 +50,6 @@ public class HadoopCredentialProviderTest {
private static java.nio.file.Path tempDir;
private static final Configuration hadoopConf = new Configuration();
- private static final Logger log = LoggerFactory.getLogger(HadoopCredentialProviderTest.class);
private static final String populatedKeyStoreName = "/accumulo.jceks";
private static final String emptyKeyStoreName = "/empty.jceks";
diff --git a/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java b/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java
index ec8ce26489..daa599a3ee 100644
--- a/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java
+++ b/minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/MiniAccumuloConfigImpl.java
@@ -29,7 +29,6 @@ import static org.apache.accumulo.minicluster.ServerType.ZOOKEEPER;
import java.io.File;
import java.io.IOException;
import java.net.MalformedURLException;
-import java.nio.file.Files;
import java.nio.file.Path;
import java.util.EnumMap;
import java.util.HashMap;
diff --git a/server/tserver/src/test/java/org/apache/accumulo/tserver/util/CreateEmptyTest.java b/server/tserver/src/test/java/org/apache/accumulo/tserver/util/CreateEmptyTest.java
index 5235acd15c..a083f6bb41 100644
--- a/server/tserver/src/test/java/org/apache/accumulo/tserver/util/CreateEmptyTest.java
+++ b/server/tserver/src/test/java/org/apache/accumulo/tserver/util/CreateEmptyTest.java
@@ -36,7 +36,6 @@ import java.io.EOFException;
import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Files;
-import java.util.concurrent.atomic.AtomicInteger;
import org.apache.accumulo.core.client.rfile.RFile;
import org.apache.accumulo.core.conf.ConfigurationCopy;
@@ -254,10 +253,4 @@ public class CreateEmptyTest extends WithTestNames {
}
}
- // tempDir is per test suite - generate a one-up count file for each call.
- private static final AtomicInteger fileCount = new AtomicInteger(0);
-
- private String genFilename(final String prefix, final String extension) {
- return prefix + fileCount.incrementAndGet() + extension;
- }
}
diff --git a/shell/src/test/java/org/apache/accumulo/shell/ShellConfigTest.java b/shell/src/test/java/org/apache/accumulo/shell/ShellConfigTest.java
index a3f0ec51d7..fc8e244873 100644
--- a/shell/src/test/java/org/apache/accumulo/shell/ShellConfigTest.java
+++ b/shell/src/test/java/org/apache/accumulo/shell/ShellConfigTest.java
@@ -37,8 +37,6 @@ import org.jline.terminal.impl.DumbTerminal;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
public class ShellConfigTest {
@@ -63,7 +61,6 @@ public class ShellConfigTest {
Shell shell;
PrintStream out;
Path config;
- private static final Logger log = LoggerFactory.getLogger(ShellConfigTest.class);
@BeforeEach
public void setUp() throws Exception {
diff --git a/test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java b/test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java
index 7276f36492..976c8ff0ea 100644
--- a/test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java
+++ b/test/src/main/java/org/apache/accumulo/test/AuditMessageIT.java
@@ -32,7 +32,6 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Iterator;
-import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.regex.Pattern;
diff --git a/test/src/main/java/org/apache/accumulo/test/ComprehensiveTableOperationsIT_SimpleSuite.java b/test/src/main/java/org/apache/accumulo/test/ComprehensiveTableOperationsIT_SimpleSuite.java
index 4112fc0a8d..8f81deaed5 100644
--- a/test/src/main/java/org/apache/accumulo/test/ComprehensiveTableOperationsIT_SimpleSuite.java
+++ b/test/src/main/java/org/apache/accumulo/test/ComprehensiveTableOperationsIT_SimpleSuite.java
@@ -848,21 +848,6 @@ public class ComprehensiveTableOperationsIT_SimpleSuite extends SharedMiniCluste
return propFound;
}
- private Set<StoredTabletFile> getStoredTabFiles(SystemTables sysTable) {
- var clientContext = (ClientContext) client;
- Set<StoredTabletFile> storedTabFiles = new HashSet<>();
- try (TabletsMetadata tabletsMetadata =
- clientContext.getAmple().readTablets().forTable(sysTable.tableId()).build()) {
- for (var tm : tabletsMetadata) {
- var stfs = tm.getFiles();
- storedTabFiles.addAll(stfs);
- stfs.forEach(f -> log.info("Found stored tablet file: {} for the system table: {}",
- f.getMetadataPath(), sysTable.tableName()));
- }
- }
- return storedTabFiles;
- }
-
private static class NoOpFilter extends Filter {
@Override
public boolean accept(Key k, Value v) {
diff --git a/test/src/main/java/org/apache/accumulo/test/ImportExportIT.java b/test/src/main/java/org/apache/accumulo/test/ImportExportIT.java
index ad6496e752..c190121d7a 100644
--- a/test/src/main/java/org/apache/accumulo/test/ImportExportIT.java
+++ b/test/src/main/java/org/apache/accumulo/test/ImportExportIT.java
@@ -32,7 +32,6 @@ import static org.junit.jupiter.api.Assertions.fail;
import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStreamReader;
-import java.nio.file.Files;
import java.time.Duration;
import java.util.Arrays;
import java.util.HashMap;