[GitHub] xuminwlt edited a comment on issue #1838: cglib FastInvoke replace the jdk Invoke

[GitBox <gi...@apache.org>]

xuminwlt edited a comment on issue #1838: cglib FastInvoke replace the jdk Invoke
URL: https://github.com/apache/incubator-shardingsphere/pull/1838#issuecomment-458446065
 
 
   use cglib invoke unit test throw -> IllegalArgumentException, different with the jdk invoke -> IllegalAccessException, ignore or replace it?
   
   ```
   @Test(expected = IllegalAccessException.class)
       @SneakyThrows
       public void assertInvokeFailure() {
           JdbcMethodInvocation actual = new JdbcMethodInvocation(JdbcMethodInvocation.build(String.class, String.class.getDeclaredMethod("indexOfSupplementary", int.class, int.class)), new Object[] {1, 1});
           actual.invoke("");
       }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services