You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Brijesh Bhalala <br...@gmail.com> on 2024/01/29 12:59:46 UTC

Re: Review Request 74843: RANGER-4659: Add eye icon for password visibility in Ranger Login Page

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74843/
-----------------------------------------------------------

(Updated Jan. 29, 2024, 12:59 p.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4659
    https://issues.apache.org/jira/browse/RANGER-4659


Repository: ranger


Description
-------

Add eye icon for password visibility in Ranger Login Page

Current Behaviour:-
1)The Ranger login page doesn't have the password visibility functionality.
2)Users can't check the entered password, in case of wrong password.

User should able to view the entered password by clicking on eye icon on password field in Ranger Login page.


Diffs
-----

  security-admin/src/main/webapp/login.jsp ad82ea9eb 
  security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js a2eeccab6 
  security-admin/src/main/webapp/styles/xa.css de8101174 


Diff: https://reviews.apache.org/r/74843/diff/3/


Testing (updated)
-------

Applied the patch on a cluster and tested the following UI scenarios :-
1)Username and Password fields in Login Page.
2)Hide and show functionality in password field.


Thanks,

Brijesh Bhalala

Re: Review Request 74843: RANGER-4659: Add eye icon for password visibility in Ranger Login Page

Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74843/#review226180
-----------------------------------------------------------


Ship it!




Ship It!

- Mugdha Varadkar


On Jan. 29, 2024, 12:59 p.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74843/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2024, 12:59 p.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4659
>     https://issues.apache.org/jira/browse/RANGER-4659
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add eye icon for password visibility in Ranger Login Page
> 
> Current Behaviour:-
> 1)The Ranger login page doesn't have the password visibility functionality.
> 2)Users can't check the entered password, in case of wrong password.
> 
> User should able to view the entered password by clicking on eye icon on password field in Ranger Login page.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/login.jsp ad82ea9eb 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js a2eeccab6 
>   security-admin/src/main/webapp/styles/xa.css de8101174 
> 
> 
> Diff: https://reviews.apache.org/r/74843/diff/3/
> 
> 
> Testing
> -------
> 
> Applied the patch on a cluster and tested the following UI scenarios :-
> 1)Username and Password fields in Login Page.
> 2)Hide and show functionality in password field.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>

Re: Review Request 74843: RANGER-4659: Add eye icon for password visibility in Ranger Login Page

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74843/#review226189
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Jan. 29, 2024, 12:59 p.m., Brijesh Bhalala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74843/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2024, 12:59 p.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
> 
> 
> Bugs: RANGER-4659
>     https://issues.apache.org/jira/browse/RANGER-4659
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Add eye icon for password visibility in Ranger Login Page
> 
> Current Behaviour:-
> 1)The Ranger login page doesn't have the password visibility functionality.
> 2)Users can't check the entered password, in case of wrong password.
> 
> User should able to view the entered password by clicking on eye icon on password field in Ranger Login page.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/login.jsp ad82ea9eb 
>   security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js a2eeccab6 
>   security-admin/src/main/webapp/styles/xa.css de8101174 
> 
> 
> Diff: https://reviews.apache.org/r/74843/diff/3/
> 
> 
> Testing
> -------
> 
> Applied the patch on a cluster and tested the following UI scenarios :-
> 1)Username and Password fields in Login Page.
> 2)Hide and show functionality in password field.
> 
> 
> Thanks,
> 
> Brijesh Bhalala
> 
>