You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/08/01 17:24:30 UTC

[5/6] impala git commit: Fix TestKuduOperations tests in test-with-docker by using consistent hostname.

Fix TestKuduOperations tests in test-with-docker by using consistent hostname.

TestKuduOperations, when run using test-with-docker, failed with errors
like:

  Remote error: Service unavailable: Timed out: could not wait for desired
  snapshot timestamp to be consistent: Tablet is lagging too much to be able to
  serve snapshot scan. Lagging by: 1985348 ms, (max is 30000 ms):

The underlying issue, as discovered by Thomas Tauber-Marshall, is that Kudu
serializes the hostnames of Kudu tablet servers, and, different containers in
test-with-docker use different hostnames.  This was exposed after "IMPALA-6812:
Fix flaky Kudu scan tests" switched to using READ_AT_SNAPSHOT for Kudu reads.

Using the same hostname for all the containers is easy and harmless;
this change does just that.

Change-Id: Iea8c5096b515a79601be2e919d32585fb2796b3d
Reviewed-on: http://gerrit.cloudera.org:8080/11082
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/abf6f8f4
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/abf6f8f4
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/abf6f8f4

Branch: refs/heads/master
Commit: abf6f8f465e6b99fdd0a97e12bbde143ef98f3db
Parents: 72db58a
Author: Philip Zeyliger <ph...@cloudera.com>
Authored: Mon Jul 30 13:15:54 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Wed Aug 1 01:25:38 2018 +0000

----------------------------------------------------------------------
 docker/test-with-docker.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/abf6f8f4/docker/test-with-docker.py
----------------------------------------------------------------------
diff --git a/docker/test-with-docker.py b/docker/test-with-docker.py
index 1922c57..3da700f 100755
--- a/docker/test-with-docker.py
+++ b/docker/test-with-docker.py
@@ -505,7 +505,14 @@ class TestWithDocker(object):
         # requirement may be lifted in newer Docker versions.
         "--privileged",
         "--name", name,
-        "--hostname", name,
+        # Whereas the container names vary across containers, we use the same
+        # hostname repeatedly, so that the build container and the test
+        # containers have the same hostnames. Kudu errors out with "Remote
+        # error: Service unavailable: Timed out: could not wait for desired
+        # snapshot timestamp to be consistent: Tablet is lagging too much to be
+        # able to serve snapshot scan." if reading with READ_AT_SNAPSHOT
+        # if the hostnames change underneath it.
+        "--hostname", self.name,
         # Label with the git root directory for easier cleanup
         "--label=pwd=" + self.git_root,
         # Consistent locales