You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/20 00:32:08 UTC
[GitHub] [kylin] weibin0516 opened a new pull request #1074: KYLIN-4340 Fix
bug of cube configuration overwrites not effective
weibin0516 opened a new pull request #1074: KYLIN-4340 Fix bug of cube configuration overwrites not effective
URL: https://github.com/apache/kylin/pull/1074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen commented on issue #1074: KYLIN-4340 Fix bug of
cube configuration overwrites not effective
Posted by GitBox <gi...@apache.org>.
nichunen commented on issue #1074: KYLIN-4340 Fix bug of cube configuration overwrites not effective
URL: https://github.com/apache/kylin/pull/1074#issuecomment-582369472
@weibin0516 Hi, I have reviewed your pr. But I think it's not a good way to fetch the cube's config in this way. In method org.apache.kylin.engine.spark.SparkBatchCubingJobBuilder2#build, try use "seg.getConfig().isSparkFactDistinctEnable()" instead, I think this should work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1074: KYLIN-4340 Fix bug of
get value of isSparkFactDistinctEnable for cube not correct
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1074: KYLIN-4340 Fix bug of get value of isSparkFactDistinctEnable for cube not correct
URL: https://github.com/apache/kylin/pull/1074#issuecomment-583814833
## Pull Request Test Coverage Report for [Build 5604](https://coveralls.io/builds/28613373)
* **0** of **1** **(0.0%)** changed or added relevant line in **1** file are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.005%**) to **27.527%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkBatchCubingJobBuilder2.java](https://coveralls.io/builds/28613373/source?filename=engine-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fspark%2FSparkBatchCubingJobBuilder2.java#L68) | 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **1** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28613373/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/28613373) |
| :-- | --: |
| Change from base [Build 5602](https://coveralls.io/builds/28603095): | 0.005% |
| Covered Lines: | 24191 |
| Relevant Lines: | 87882 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] weibin0516 commented on issue #1074: KYLIN-4340 Fix bug of
cube configuration overwrites not effective
Posted by GitBox <gi...@apache.org>.
weibin0516 commented on issue #1074: KYLIN-4340 Fix bug of cube configuration overwrites not effective
URL: https://github.com/apache/kylin/pull/1074#issuecomment-582765238
@nichunen , config isSparkFactDistinctEnable is just a example, this is a bug, this bug will cause all cube config not effective
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1074: KYLIN-4340 Fix bug of
get value of isSparkFactDistinctEnable for cube not correct
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1074: KYLIN-4340 Fix bug of get value of isSparkFactDistinctEnable for cube not correct
URL: https://github.com/apache/kylin/pull/1074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services