[GitHub] merlimat commented on issue #1254: Fixes for multiple journals recovery

[GitBox <gi...@apache.org>]

merlimat commented on issue #1254: Fixes for multiple journals recovery
URL: https://github.com/apache/bookkeeper/pull/1254#issuecomment-373220719
 
 
   > Hey @merlimat in 88addff "lastMark" filename is hardcoded. Probably it also needs to be fixed.
   
   @reddycharan I don't think that is a problem. I don't see usages of harcoded `"lastMark" outside that checkpoint test, where's it's anyway fine since it's running with 1 single journal.
   
   ```
   $ git grep '"lastMark"'
   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/FileSystemUpgrade.java:                    || name.equals("lastId") || name.startsWith("lastMark")) {
   bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:    private static final String LAST_MARK_DEFAULT_NAME = "lastMark";
   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerStorageCheckpointTest.java:        File lastMarkFile = new File(ledgerDir, "lastMark");
   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerStorageCheckpointTest.java:        File lastMarkFile = new File(ledgerDir, "lastMark");
   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerStorageCheckpointTest.java:        File lastMarkFile = new File(ledgerDir, "lastMark");
   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerStorageCheckpointTest.java:        File lastMarkFile = new File(ledgerDir, "lastMark");
   bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerStorageCheckpointTest.java:        lastMarkFile = new File(ledgerDir, "lastMark");
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services