[jira] [Comment Edited] (TS-3485) We should honor ip_allow.config ACLs for HTTP/2 streams

["James Peach (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15269812#comment-15269812 ] 

James Peach edited comment on TS-3485 at 5/3/16 11:12 PM:
----------------------------------------------------------

Why is the ACL on {{Http2ClientSession::new_connection}} for HTTP/2 but on {{HttpSessionAccept::accept}} for HTTP/1.1?

In the HTTP/2 case, it looks like the code warns but doesn't actually deny access?

Can we refactor this to that ACLs are checked in one place?


was (Author: jamespeach):
Why is the ACL on {[Http2ClientSession::new_connection}} for HTTP/2 but on {{HttpSessionAccept::accept}} for HTTP/1.1?

In the HTTP/2 case, it looks like the code warns but doesn't actually deny access?

Can we refactor this to that ACLs are checked in one place?

> We should honor ip_allow.config ACLs for HTTP/2 streams
> -------------------------------------------------------
>
>                 Key: TS-3485
>                 URL: https://issues.apache.org/jira/browse/TS-3485
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP/2
>            Reporter: Leif Hedstrom
>            Assignee: Susan Hinrichs
>             Fix For: 7.0.0
>
>
> From the comments:
> {code}
> // XXX we need to refactor the ACL checks from HttpSessionAccept so that we can invoke them here, and also in
> // the SPDY protocol layer ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)