You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "alberto-art3ch (via GitHub)" <gi...@apache.org> on 2025/03/20 18:58:32 UTC
[PR] FINERACT-2197: Introduce a new type of ACTUAL during calculation of d… [fineract]
alberto-art3ch opened a new pull request, #4492:
URL: https://github.com/apache/fineract/pull/4492
…ays in year, update
## Description
Allow the update for the new flag `days_in_year_custom_strategy` and calculations for values in case of Days In Years set to ACTUAL.
`FULL_LEAP_YEAR`: 366 days for full leap year. → This is the by default value!
`FEB_29_PERIOD_ONLY`: 366 days for period of February 29
[FINERACT-2197](https://issues.apache.org/jira/browse/FINERACT-2197)
<img width="1502" alt="Screenshot 2025-03-20 at 10 58 57 a m" src="https://github.com/user-attachments/assets/1304df3e-bc5d-4c18-97b3-ce15c7a956ed" />
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2197: Introduce a new type of ACTUAL during calculation of d… [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4492:
URL: https://github.com/apache/fineract/pull/4492#discussion_r2010183007
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -1402,6 +1366,9 @@ private GetLoanCharge() {}
@Schema(example = "[]")
public List<Integer> numberOfRepaymentVariationsForBorrowerCycle;
public GetLoanProductsResponse.GetLoanProductsAccountingRule accountingRule;
+ public StringEnumOptionData daysInMonthType;
+ public StringEnumOptionData daysInYearType;
+ public StringEnumOptionData daysInYearCustomStrategy;
Review Comment:
Only `daysInYearCustomStrategy` is String enum option.. the `daysInMonthType` and `daysInYearType` are `EnumOptionData` please modify them back!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2197: Introduce a new type of ACTUAL during calculation of d… [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #4492:
URL: https://github.com/apache/fineract/pull/4492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org